Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: ui/gl/gl_surface.h

Issue 2702403009: Make surface GetFormat pure virtual, add missing overrides. (Closed)
Patch Set: Fix class name for Windows Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gpu/ipc/service/image_transport_surface_overlay_mac.mm ('k') | ui/gl/gl_surface.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_GL_GL_SURFACE_H_ 5 #ifndef UI_GL_GL_SURFACE_H_
6 #define UI_GL_GL_SURFACE_H_ 6 #define UI_GL_GL_SURFACE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 // available. 150 // available.
151 virtual void* GetDisplay(); 151 virtual void* GetDisplay();
152 152
153 // Get the platfrom specific configuration for this surface, if available. 153 // Get the platfrom specific configuration for this surface, if available.
154 virtual void* GetConfig(); 154 virtual void* GetConfig();
155 155
156 // Get the key corresponding to the set of GLSurfaces that can be made current 156 // Get the key corresponding to the set of GLSurfaces that can be made current
157 // with this GLSurface. 157 // with this GLSurface.
158 virtual unsigned long GetCompatibilityKey(); 158 virtual unsigned long GetCompatibilityKey();
159 159
160 // Get the GL pixel format of the surface, if available. 160 // Get the GL pixel format of the surface. Must be implemented in a
161 virtual GLSurfaceFormat GetFormat(); 161 // subclass, though it's ok to just "return GLSurfaceFormat()" if
162 // the default is appropriate.
163 virtual GLSurfaceFormat GetFormat() = 0;
162 164
163 // Get access to a helper providing time of recent refresh and period 165 // Get access to a helper providing time of recent refresh and period
164 // of screen refresh. If unavailable, returns NULL. 166 // of screen refresh. If unavailable, returns NULL.
165 virtual gfx::VSyncProvider* GetVSyncProvider(); 167 virtual gfx::VSyncProvider* GetVSyncProvider();
166 168
167 // Schedule an overlay plane to be shown at swap time, or on the next 169 // Schedule an overlay plane to be shown at swap time, or on the next
168 // CommitOverlayPlanes call. 170 // CommitOverlayPlanes call.
169 // |z_order| specifies the stacking order of the plane relative to the 171 // |z_order| specifies the stacking order of the plane relative to the
170 // main framebuffer located at index 0. For the case where there is no 172 // main framebuffer located at index 0. For the case where there is no
171 // main framebuffer, overlays may be scheduled at 0, taking its place. 173 // main framebuffer, overlays may be scheduled at 0, taking its place.
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 // initialization fails. 293 // initialization fails.
292 GL_EXPORT scoped_refptr<GLSurface> InitializeGLSurface( 294 GL_EXPORT scoped_refptr<GLSurface> InitializeGLSurface(
293 scoped_refptr<GLSurface> surface); 295 scoped_refptr<GLSurface> surface);
294 296
295 GL_EXPORT scoped_refptr<GLSurface> InitializeGLSurfaceWithFormat( 297 GL_EXPORT scoped_refptr<GLSurface> InitializeGLSurfaceWithFormat(
296 scoped_refptr<GLSurface> surface, GLSurfaceFormat format); 298 scoped_refptr<GLSurface> surface, GLSurfaceFormat format);
297 299
298 } // namespace gl 300 } // namespace gl
299 301
300 #endif // UI_GL_GL_SURFACE_H_ 302 #endif // UI_GL_GL_SURFACE_H_
OLDNEW
« no previous file with comments | « gpu/ipc/service/image_transport_surface_overlay_mac.mm ('k') | ui/gl/gl_surface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698