Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2702403007: Fix BlobBytesConsumer leak (Closed)

Created:
3 years, 10 months ago by yhirano
Modified:
3 years, 10 months ago
Reviewers:
dmurph
CC:
chromium-reviews, haraken, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix BlobBytesConsumer leak This CL fixes a BlobBytesConsumer leak caused by mis-setting blob URL and a lack of revokePublicBlobURL call. R=dmurph@chromium.org BUG=695250 Review-Url: https://codereview.chromium.org/2702403007 Cr-Commit-Position: refs/heads/master@{#452715} Committed: https://chromium.googlesource.com/chromium/src/+/0486b0ab21ee916488a991e3654e00220f787ae8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/fetch/BlobBytesConsumer.cpp View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
yhirano
3 years, 10 months ago (2017-02-23 05:18:48 UTC) #3
dmurph
lgtm
3 years, 10 months ago (2017-02-23 20:12:40 UTC) #6
dmurph
On 2017/02/23 20:12:40, dmurph wrote: > lgtm Thanks for the patch!
3 years, 10 months ago (2017-02-23 20:12:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702403007/1
3 years, 10 months ago (2017-02-24 02:04:57 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 02:12:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0486b0ab21ee916488a991e3654e...

Powered by Google App Engine
This is Rietveld 408576698