Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2702393002:
Add a base::Feature for the pref service. (Closed)
|
Created:
3 years, 10 months ago by Sam McNally Modified:
3 years, 10 months ago CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd a base::Feature for the pref service.
This is currently unused, but will gate the use of the servicified pref
service.
BUG=654988
Review-Url: https://codereview.chromium.org/2702393002
Cr-Commit-Position: refs/heads/master@{#451695}
Committed: https://chromium.googlesource.com/chromium/src/+/ea9d08f4944bceff2ea83ec55778254eeb1d0c5e
Patch Set 1 : #
Messages
Total messages: 24 (16 generated)
Description was changed from ========== Add a base::Feature for the prefs service. BUG=654988 ========== to ========== Add a base::Feature for the prefs service. This is currently unused, but will gate the use of a servicified PrefService. BUG=654988 ==========
Description was changed from ========== Add a base::Feature for the prefs service. This is currently unused, but will gate the use of a servicified PrefService. BUG=654988 ========== to ========== Add a base::Feature for the prefs service. This is currently unused, but will gate the use of the servicified PrefService. BUG=654988 ==========
Description was changed from ========== Add a base::Feature for the prefs service. This is currently unused, but will gate the use of the servicified PrefService. BUG=654988 ========== to ========== Add a base::Feature for the pref service. This is currently unused, but will gate the use of the servicified PrefService. BUG=654988 ==========
Description was changed from ========== Add a base::Feature for the pref service. This is currently unused, but will gate the use of the servicified PrefService. BUG=654988 ========== to ========== Add a base::Feature for the pref service. This is currently unused, but will gate the use of the servicified PrefService. BUG=654988 ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
sammc@chromium.org changed reviewers: + tibell@chromium.org
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add a base::Feature for the pref service. This is currently unused, but will gate the use of the servicified PrefService. BUG=654988 ========== to ========== Add a base::Feature for the pref service. This is currently unused, but will gate the use of the servicified pref service. BUG=654988 ==========
lgtm
The CQ bit was checked by sammc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
sammc@chromium.org changed reviewers: + noel@chromium.org
On 2017/02/21 03:43:38, Sam McNally wrote: LGTM ified.
The CQ bit was checked by sammc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487648923865870,
"parent_rev": "158ecdd2519ced8dd83dfd33aef9f05f00b074f1", "commit_rev":
"ea9d08f4944bceff2ea83ec55778254eeb1d0c5e"}
Message was sent while issue was closed.
Description was changed from ========== Add a base::Feature for the pref service. This is currently unused, but will gate the use of the servicified pref service. BUG=654988 ========== to ========== Add a base::Feature for the pref service. This is currently unused, but will gate the use of the servicified pref service. BUG=654988 Review-Url: https://codereview.chromium.org/2702393002 Cr-Commit-Position: refs/heads/master@{#451695} Committed: https://chromium.googlesource.com/chromium/src/+/ea9d08f4944bceff2ea83ec55778... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as https://chromium.googlesource.com/chromium/src/+/ea9d08f4944bceff2ea83ec55778... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
