[Debugger] Add a ReturnValueScope to correctly handle return values in nested debug breaks.

[Debugger] Add a ReturnValueScope to correctly handle return values in nested debug breaks.

Decouples return value handling from DebugScope when handling nested break
statements. Return values are handled in ReturnValueScope. This would correctly
reset the return_values when exiting the break statements.

BUG=chromium:688950
Review-Url: https://codereview.chromium.org/2702343003
Cr-Commit-Position: refs/heads/master@{#43343}
Committed: https://chromium.googlesource.com/v8/v8/+/0b709628deb6cc2e1fe1dbbef9219fa10a5b208c

[mythria, 2017-02-20 18:00:07]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 18:00:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mythria, 2017-02-20 18:04:23]

Description was changed from

==========
[Debugger] Add a ReturnValueScope to handle return values in nested debug
breaks.

Decouples return value handling from DebugScope when handling nested break
statements. DebugScope is not the correct place to handle the return values,
they should be handled in Runtime_DebugBreak functions. This would correctly
reset the return_values.

BUG=v8:688950
==========

to

==========
[Debugger] Add a ReturnValueScope to handle return values in nested debug
breaks.

Decouples return value handling from DebugScope when handling nested break
statements. Return values are handled in ReturnValueScope. This would correctly
reset the return_values.

BUG=v8:688950
==========

[mythria, 2017-02-20 18:04:42]

Description was changed from

==========
[Debugger] Add a ReturnValueScope to handle return values in nested debug
breaks.

Decouples return value handling from DebugScope when handling nested break
statements. Return values are handled in ReturnValueScope. This would correctly
reset the return_values.

BUG=v8:688950
==========

to

==========
[Debugger] Add a ReturnValueScope to handle return values in nested debug
breaks.

Decouples return value handling from DebugScope when handling nested break
statements. Return values are handled in ReturnValueScope. This would correctly
reset the return_values when exiting the break statements.

BUG=v8:688950
==========

[commit-bot: I haz the power, 2017-02-20 18:23:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 18:23:51]

Dry run: This issue passed the CQ dry run.

[mythria, 2017-02-21 09:52:28]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 09:52:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mythria, 2017-02-21 09:53:33]

Description was changed from

==========
[Debugger] Add a ReturnValueScope to handle return values in nested debug
breaks.

Decouples return value handling from DebugScope when handling nested break
statements. Return values are handled in ReturnValueScope. This would correctly
reset the return_values when exiting the break statements.

BUG=v8:688950
==========

to

==========
[Debugger] Add a ReturnValueScope to correctly handle return values in nested
debug breaks.

Decouples return value handling from DebugScope when handling nested break
statements. Return values are handled in ReturnValueScope. This would correctly
reset the return_values when exiting the break statements.

BUG=v8:688950
==========

[mythria, 2017-02-21 09:54:19]

mythria@chromium.org changed reviewers:
+ yangguo@chromium.org

[mythria, 2017-02-21 09:54:20]

Could you please take a look.

Thanks,
Mythri

[Yang, 2017-02-21 10:04:15]

On 2017/02/21 09:54:20, mythria wrote:
> Could you please take a look.
> 
> Thanks,
> Mythri

lgtm. Did you verify that this fixes the leak issue?

[commit-bot: I haz the power, 2017-02-21 10:12:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 10:12:17]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/22964)
  v8_win64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)

[mythria, 2017-02-21 12:10:58]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 12:11:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 12:34:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 12:34:57]

Dry run: This issue passed the CQ dry run.

[mythria, 2017-02-21 13:09:51]

Thanks Yang. I verified that it fixes the Dom leak problem. 

I did one more change. I moved HandleScope to the Runtime_Debug functions
instead of Break. PTAL.

[Yang, 2017-02-21 13:12:28]

On 2017/02/21 13:09:51, mythria wrote:
> Thanks Yang. I verified that it fixes the Dom leak problem. 
> 
> I did one more change. I moved HandleScope to the Runtime_Debug functions
> instead of Break. PTAL.

Seems reasonable to me. LGTM.

[mythria, 2017-02-21 13:43:30]

The CQ bit was checked by mythria@chromium.org

[commit-bot: I haz the power, 2017-02-21 13:43:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 13:45:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487684610839970,
"parent_rev": "fbee722c918ea3842f3e0f3c276860603c4b649b", "commit_rev":
"0b709628deb6cc2e1fe1dbbef9219fa10a5b208c"}

[commit-bot: I haz the power, 2017-02-21 13:45:41]

Description was changed from

==========
[Debugger] Add a ReturnValueScope to correctly handle return values in nested
debug breaks.

Decouples return value handling from DebugScope when handling nested break
statements. Return values are handled in ReturnValueScope. This would correctly
reset the return_values when exiting the break statements.

BUG=v8:688950
==========

to

==========
[Debugger] Add a ReturnValueScope to correctly handle return values in nested
debug breaks.

Decouples return value handling from DebugScope when handling nested break
statements. Return values are handled in ReturnValueScope. This would correctly
reset the return_values when exiting the break statements.

BUG=v8:688950

Review-Url: https://codereview.chromium.org/2702343003
Cr-Commit-Position: refs/heads/master@{#43343}
Committed:
https://chromium.googlesource.com/v8/v8/+/0b709628deb6cc2e1fe1dbbef9219fa10a5...
==========

[commit-bot: I haz the power, 2017-02-21 13:45:42]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/0b709628deb6cc2e1fe1dbbef9219fa10a5...

[mythria, 2017-02-22 13:58:34]

Description was changed from

==========
[Debugger] Add a ReturnValueScope to correctly handle return values in nested
debug breaks.

Decouples return value handling from DebugScope when handling nested break
statements. Return values are handled in ReturnValueScope. This would correctly
reset the return_values when exiting the break statements.

BUG=v8:688950

Review-Url: https://codereview.chromium.org/2702343003
Cr-Commit-Position: refs/heads/master@{#43343}
Committed:
https://chromium.googlesource.com/v8/v8/+/0b709628deb6cc2e1fe1dbbef9219fa10a5...
==========

to

==========
[Debugger] Add a ReturnValueScope to correctly handle return values in nested
debug breaks.

Decouples return value handling from DebugScope when handling nested break
statements. Return values are handled in ReturnValueScope. This would correctly
reset the return_values when exiting the break statements.

BUG=chromium:688950

Review-Url: https://codereview.chromium.org/2702343003
Cr-Commit-Position: refs/heads/master@{#43343}
Committed:
https://chromium.googlesource.com/v8/v8/+/0b709628deb6cc2e1fe1dbbef9219fa10a5...
==========