Remove unused imports and fix some other linter errors.

Remove unused imports and fix some other linter errors.

R=iannucci@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2702313003
Committed: https://github.com/luci/recipes-py/commit/0583864aaa098dd42dec532d31e0faeb2841170c

[Vadim Sh., 2017-02-21 05:46:26]

PTAL

My editor highlights unused imports and some other errors. They stick our as
sore thumb. Was reading the code, decided to fix along the way...

(Also, why does pylint ignore this?)

https://codereview.chromium.org/2702313003/diff/1/recipe_engine/package.py
File recipe_engine/package.py (left):

https://codereview.chromium.org/2702313003/diff/1/recipe_engine/package.py#ol...
recipe_engine/package.py:376: def __repr__(self):
was defined twice (second definition on line 404, kept it)

https://codereview.chromium.org/2702313003/diff/1/recipe_engine/package.py
File recipe_engine/package.py (right):

https://codereview.chromium.org/2702313003/diff/1/recipe_engine/package.py#ne...
recipe_engine/package.py:227: info = self._get_commit_info(rev, context)
Looks like unnecessary call, unless self.backend actually keeps some state
internally, updated by _get_commit_info...

https://codereview.chromium.org/2702313003/diff/1/recipe_engine/simulation_te...
File recipe_engine/simulation_test.py (left):

https://codereview.chromium.org/2702313003/diff/1/recipe_engine/simulation_te...
recipe_engine/simulation_test.py:28: from expect_tests.util import covers as
expect_tests_covers
I hope it isn't some magical import that enables something by being imported?

https://codereview.chromium.org/2702313003/diff/1/recipe_engine/step_runner.py
File recipe_engine/step_runner.py (right):

https://codereview.chromium.org/2702313003/diff/1/recipe_engine/step_runner.p...
recipe_engine/step_runner.py:5: import calendar
used on line 388, but wasn't imported

[Vadim Sh., 2017-02-21 05:47:40]

The CQ bit was checked by vadimsh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 05:47:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 05:53:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 05:53:15]

Dry run: Try jobs failed on following builders:
  Recipes-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/347807cd13e4fd10)

[Vadim Sh., 2017-02-21 05:56:07]

Welp... coverage error. Some magic was lost somewhere :(

[Vadim Sh., 2017-02-21 05:57:20]

On 2017/02/21 05:56:07, Vadim Sh. wrote:
> Welp... coverage error. Some magic was lost somewhere :(

Hm. The error is present on HEAD too, and it's flaky.

[iannucci, 2017-02-21 06:07:46]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2017-02-21 06:07:47]

lgtm

I've been cleaning these up piecemeal... didn't realize it was this bad.

https://codereview.chromium.org/2702313003/diff/1/recipe_engine/simulation_te...
File recipe_engine/simulation_test.py (left):

https://codereview.chromium.org/2702313003/diff/1/recipe_engine/simulation_te...
recipe_engine/simulation_test.py:28: from expect_tests.util import covers as
expect_tests_covers
On 2017/02/21 05:46:26, Vadim Sh. wrote:
> I hope it isn't some magical import that enables something by being imported?

Shouldn't be...

[commit-bot: I haz the power, 2017-02-21 06:07:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iannucci, 2017-02-21 06:12:31]

On 2017/02/21 06:07:51, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

hmm...

[commit-bot: I haz the power, 2017-02-21 06:14:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487657266783670, "parent_rev":
"419045652e20cb31a22ef9c761bea91b05df0cbb", "commit_rev":
"0583864aaa098dd42dec532d31e0faeb2841170c"}

[commit-bot: I haz the power, 2017-02-21 06:14:54]

Description was changed from

==========
Remove unused imports and fix some other linter errors.

R=iannucci@chromium.org
BUG=
==========

to

==========
Remove unused imports and fix some other linter errors.

R=iannucci@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2702313003
Committed:
https://github.com/luci/recipes-py/commit/0583864aaa098dd42dec532d31e0faeb284...
==========

[commit-bot: I haz the power, 2017-02-21 06:14:55]

Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/0583864aaa098dd42dec532d31e0faeb284...