bindings: Simplifies WindowProxyManager and its relation to Frame.

third_party/WebKit/Source/core/frame/LocalFrame.cpp

Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
index 6fa75cf9bc647ce1230b616b021a0adf8eee7440..59ff05e32fabfd225a61ec2d4fd60bfc4f357d71 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
@@ -361,10 +361,6 @@ DEFINE_TRACE(LocalFrame) {
   Supplementable<LocalFrame>::trace(visitor);
 }
 
-WindowProxy* LocalFrame::windowProxy(DOMWrapperWorld& world) {
-  return m_script->windowProxy(world);
-}
-
 void LocalFrame::navigate(Document& originDocument,
                           const KURL& url,
                           bool replaceCurrentItem,
@@ -493,10 +489,6 @@ void LocalFrame::printNavigationWarning(const String& message) {
       ConsoleMessage::create(JSMessageSource, WarningMessageLevel, message));
 }
 
-WindowProxyManagerBase* LocalFrame::getWindowProxyManager() const {
-  return m_script->getWindowProxyManager();
-}
-
 bool LocalFrame::shouldClose() {
   // TODO(dcheng): This should be fixed to dispatch beforeunload events to
   // both local and remote frames.
@@ -853,12 +845,14 @@ inline LocalFrame::LocalFrame(LocalFrameClient* client,
                               FrameOwner* owner,
                               InterfaceProvider* interfaceProvider,
                               InterfaceRegistry* interfaceRegistry)
-    : Frame(client, host, owner),
+    : Frame(client, host, owner, LocalWindowProxyManager::create(*this)),
       m_frameScheduler(page()->chromeClient().createFrameScheduler(
           client->frameBlameContext())),
       m_loader(this),
       m_navigationScheduler(NavigationScheduler::create(this)),
-      m_script(ScriptController::create(this)),
+      m_script(ScriptController::create(
+          this,
+          static_cast<LocalWindowProxyManager*>(getWindowProxyManager()))),

[haraken, 2017/03/10 12:44:12]

Hmm, it looks a bit redundant that LocalFrame has m_script and
m_windowProxyManager. Is there any way to refactor code to drop one of the
pointers?

[Yuki, 2017/03/10 15:21:51]

ScriptController::ScriptController(LocalFrame& frame)
    : m_frame(&frame) {}
ScriptController::getWindowProxyManager() {
  return m_frame->getWindowProxyManager();
}

Then, we don't need to directly pass a WindowProxyManager to ScriptController. 
I'm not sure if this is a good idea.

[haraken, 2017/03/11 19:35:25]

It's fine that ScriptController has m_windowProxyManager.

I'm wondering why LocalFrame needs to hold both m_script (on LocalFrame) and
m_windowProxyManager (on Frame).

       m_editor(Editor::create(*this)),
       m_spellChecker(SpellChecker::create(*this)),
       m_selection(FrameSelection::create(*this)),