bindings: Simplifies WindowProxyManager and its relation to Frame.

third_party/WebKit/Source/core/frame/LocalFrame.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Simon Hausmann <hausmann@kde.org>
  *                     2000 Stefan Schimanski <1Stein@gmx.de>
  *                     2001 George Staikos <staikos@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com>
@@ skipping 343 matching lines @@
   visitor->trace(m_editor);
   visitor->trace(m_spellChecker);
   visitor->trace(m_selection);
   visitor->trace(m_eventHandler);
   visitor->trace(m_console);
   visitor->trace(m_inputMethodController);
   Frame::trace(visitor);
   Supplementable<LocalFrame>::trace(visitor);
 }
 
-WindowProxy* LocalFrame::windowProxy(DOMWrapperWorld& world) {
-  return m_script->windowProxy(world);
-}
-
 void LocalFrame::navigate(Document& originDocument,
                           const KURL& url,
                           bool replaceCurrentItem,
                           UserGestureStatus userGestureStatus) {
   m_navigationScheduler->scheduleLocationChange(&originDocument, url,
                                                 replaceCurrentItem);
 }
 
 void LocalFrame::navigate(const FrameLoadRequest& request) {
   m_loader.load(request);
@@ skipping 108 matching lines @@
       document()->url().getString() + "'. " + reason + "\n";
 
   domWindow()->printErrorMessage(message);
 }
 
 void LocalFrame::printNavigationWarning(const String& message) {
   m_console->addMessage(
       ConsoleMessage::create(JSMessageSource, WarningMessageLevel, message));
 }
 
-WindowProxyManagerBase* LocalFrame::getWindowProxyManager() const {
-  return m_script->getWindowProxyManager();
-}
-
 bool LocalFrame::shouldClose() {
   // TODO(dcheng): This should be fixed to dispatch beforeunload events to
   // both local and remote frames.
   return m_loader.shouldClose();
 }
 
 void LocalFrame::detachChildren() {
   DCHECK(m_loader.stateMachine()->creatingInitialEmptyDocument() || document());
 
   if (Document* document = this->document())
@@ skipping 336 matching lines @@
 
 bool LocalFrame::shouldThrottleRendering() const {
   return view() && view()->shouldThrottleRendering();
 }
 
 inline LocalFrame::LocalFrame(LocalFrameClient* client,
                               FrameHost* host,
                               FrameOwner* owner,
                               InterfaceProvider* interfaceProvider,
                               InterfaceRegistry* interfaceRegistry)
-    : Frame(client, host, owner),
+    : Frame(client, host, owner, LocalWindowProxyManager::create(*this)),
       m_frameScheduler(page()->chromeClient().createFrameScheduler(
           client->frameBlameContext())),
       m_loader(this),
       m_navigationScheduler(NavigationScheduler::create(this)),
-      m_script(ScriptController::create(this)),
+      m_script(ScriptController::create(
+          this,
+          static_cast<LocalWindowProxyManager*>(getWindowProxyManager()))),

[haraken, 2017/03/10 12:44:12]

Hmm, it looks a bit redundant that LocalFrame has m_script and
m_windowProxyManager. Is there any way to refactor code to drop one of the
pointers?

[Yuki, 2017/03/10 15:21:51]

ScriptController::ScriptController(LocalFrame& frame)
    : m_frame(&frame) {}
ScriptController::getWindowProxyManager() {
  return m_frame->getWindowProxyManager();
}

Then, we don't need to directly pass a WindowProxyManager to ScriptController. 
I'm not sure if this is a good idea.

[haraken, 2017/03/11 19:35:25]

It's fine that ScriptController has m_windowProxyManager.

I'm wondering why LocalFrame needs to hold both m_script (on LocalFrame) and
m_windowProxyManager (on Frame).

       m_editor(Editor::create(*this)),
       m_spellChecker(SpellChecker::create(*this)),
       m_selection(FrameSelection::create(*this)),
       m_eventHandler(new EventHandler(*this)),
       m_console(FrameConsole::create(*this)),
       m_inputMethodController(InputMethodController::create(*this)),
       m_navigationDisableCount(0),
       m_pageZoomFactor(parentPageZoomFactor(this)),
       m_textZoomFactor(parentTextZoomFactor(this)),
       m_inViewSourceMode(false),
@@ skipping 44 matching lines @@
   if (m_frame && m_frame->client() && m_frame->client()->frameBlameContext())
     m_frame->client()->frameBlameContext()->Enter();
 }
 
 ScopedFrameBlamer::~ScopedFrameBlamer() {
   if (m_frame && m_frame->client() && m_frame->client()->frameBlameContext())
     m_frame->client()->frameBlameContext()->Leave();
 }
 
 }  // namespace blink