Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2702273002:
Fix a memory leak in ios bookmarks. (Closed)
|
Created:
3 years, 10 months ago by stkhapugin Modified:
3 years, 10 months ago Reviewers:
marq (ping after 24h) CC:
chromium-reviews, marq+watch_chromium.org, tfarina, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFixes a memory leak in bookmarks detected with static analyzer.
BUG=686838
Review-Url: https://codereview.chromium.org/2702273002
Cr-Commit-Position: refs/heads/master@{#451628}
Committed: https://chromium.googlesource.com/chromium/src/+/13781f5c8e8f44939079dd8fd9ccfc14ba70048e
Patch Set 1 #Patch Set 2 : second leak #Patch Set 3 : rebase #Patch Set 4 : revert #
Messages
Total messages: 20 (16 generated)
Description was changed from ========== leaks BUG= ========== to ========== Fixes two memory leaks detected with static analyzer. BUG=686838 ==========
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
stkhapugin@chromium.org changed reviewers: + marq@chromium.org
ptal
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
Description was changed from ========== Fixes two memory leaks detected with static analyzer. BUG=686838 ========== to ========== Fixes a memory leak in bookmarks detected with static analyzer. BUG=686838 ==========
lgtm
The CQ bit was checked by stkhapugin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487602074785240,
"parent_rev": "2593372e3ff1af1415f0f53b19078b99e6709483", "commit_rev":
"13781f5c8e8f44939079dd8fd9ccfc14ba70048e"}
Message was sent while issue was closed.
Description was changed from ========== Fixes a memory leak in bookmarks detected with static analyzer. BUG=686838 ========== to ========== Fixes a memory leak in bookmarks detected with static analyzer. BUG=686838 Review-Url: https://codereview.chromium.org/2702273002 Cr-Commit-Position: refs/heads/master@{#451628} Committed: https://chromium.googlesource.com/chromium/src/+/13781f5c8e8f44939079dd8fd9cc... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/13781f5c8e8f44939079dd8fd9cc... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
