Ensure that mixed content checks preceed HSTS checks.

Ensure that mixed content checks preceed HSTS checks.

BUG=692157
R=carlosk@chromium.org

Review-Url: https://codereview.chromium.org/2702263002
Cr-Commit-Position: refs/heads/master@{#451916}
Committed: https://chromium.googlesource.com/chromium/src/+/a6345fb8100733f36a40b8578c38ec3980919780

[Mike West, 2017-02-20 12:26:42]

The CQ bit was checked by mkwst@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 12:27:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mike West, 2017-02-20 12:27:14]

WDYT, Carlos?

[commit-bot: I haz the power, 2017-02-20 14:05:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 14:05:25]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mike West, 2017-02-21 14:17:15]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org

[Mike West, 2017-02-21 14:17:16]

WD_Y_T, Jochen? :)

[carlosk, 2017-02-21 19:23:01]

RS LGTM as I'm not an expert in HSTS.

I did run this test with PlzNavigate enabled and the only problem I had was that
the "line 18:" log snippet didn't show up. Otherwise the block happened as
expected.

[carlosk, 2017-02-21 19:32:34]

Description was changed from

==========
Ensure that mixed content checks preceed HSTS checks.

BUG=576270
R=carlosk@chromium.org
==========

to

==========
Ensure that mixed content checks preceed HSTS checks.

BUG=692157
R=carlosk@chromium.org
==========

[carlosk, 2017-02-21 19:33:05]

I also updated the description to point to the more specific mixed content +
HSTS issue.

[carlosk, 2017-02-21 19:37:35]

And BTW, thanks for creating this test! :)

[Mike West, 2017-02-22 06:32:28]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2017-02-22 06:34:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 08:01:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487745148228600, "parent_rev":
"0746c1bd31524520714d53ab8e9f593730efa78a", "commit_rev":
"a6345fb8100733f36a40b8578c38ec3980919780"}

[commit-bot: I haz the power, 2017-02-22 08:07:00]

Description was changed from

==========
Ensure that mixed content checks preceed HSTS checks.

BUG=692157
R=carlosk@chromium.org
==========

to

==========
Ensure that mixed content checks preceed HSTS checks.

BUG=692157
R=carlosk@chromium.org

Review-Url: https://codereview.chromium.org/2702263002
Cr-Commit-Position: refs/heads/master@{#451916}
Committed:
https://chromium.googlesource.com/chromium/src/+/a6345fb8100733f36a40b8578c38...
==========

[commit-bot: I haz the power, 2017-02-22 08:07:02]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a6345fb8100733f36a40b8578c38...