Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 2702253002: [ObjC ARC] Converts ios/chrome/app/startup:startup to ARC. (Closed)

Created:
3 years, 10 months ago by stkhapugin
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/app/startup:startup to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2702253002 Cr-Commit-Position: refs/heads/master@{#451615} Committed: https://chromium.googlesource.com/chromium/src/+/ea17954554e8b06addf76b35be0c7d67918e85e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -4 lines) Patch
M ios/chrome/app/startup/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/app/startup/background_upload_alert.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/app/startup/chrome_main_starter.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/app/startup/client_registration.mm View 1 chunk +4 lines, -1 line 0 comments Download
M ios/chrome/app/startup/ios_chrome_main.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/app/startup/ios_chrome_main_delegate.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/app/startup/network_stack_setup.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/app/startup/provider_registration.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/app/startup/register_experimental_settings.mm View 2 chunks +5 lines, -3 lines 0 comments Download
M ios/chrome/app/startup/setup_debugging.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
stkhapugin
PTAL
3 years, 10 months ago (2017-02-20 12:11:44 UTC) #4
marq (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-20 12:26:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702253002/1
3 years, 10 months ago (2017-02-20 13:21:42 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 13:26:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ea17954554e8b06addf76b35be0c...

Powered by Google App Engine
This is Rietveld 408576698