third_party/WebKit/Source/modules/webaudio/ConvolverNode.h - Issue 2702243003: Disallow cross-thread Persistent<> read access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/ConvolverNode.h

Issue 2702243003: Disallow cross-thread Persistent<> read access. (Closed)

Patch Set: rebased upto r451733 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/ConvolverNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/ConvolverNode.h b/third_party/WebKit/Source/modules/webaudio/ConvolverNode.h

index b87197ece9675be86781a1b5b78d01dc59b51dff..90857b3f8c424653680cdba1ad4d123cdcfb51ac 100644

--- a/third_party/WebKit/Source/modules/webaudio/ConvolverNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/ConvolverNode.h

@@ -63,7 +63,8 @@ class MODULES_EXPORT ConvolverHandler final : public AudioHandler {

std::unique_ptr<Reverb> m_reverb;

// This Persistent doesn't make a reference cycle including the owner

// ConvolverNode.

- Persistent<AudioBuffer> m_buffer;

+ // It is cross-thread, as it will be accessed by the audio and main threads.

+ CrossThreadPersistent<AudioBuffer> m_buffer;

// This synchronizes dynamic changes to the convolution impulse response with

// process().