third_party/WebKit/Source/core/testing/DummyPageHolder.h - Issue 2702243003: Disallow cross-thread Persistent<> read access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/DummyPageHolder.h

Issue 2702243003: Disallow cross-thread Persistent<> read access. (Closed)

Patch Set: rebase fixup Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/testing/DummyPageHolder.h

diff --git a/third_party/WebKit/Source/core/testing/DummyPageHolder.h b/third_party/WebKit/Source/core/testing/DummyPageHolder.h

index b914fd60f88f13ee472cbe2f929f207420268011..023ac7b600ffbe495bd2b16d0aae0b3634b6d3ea 100644

--- a/third_party/WebKit/Source/core/testing/DummyPageHolder.h

+++ b/third_party/WebKit/Source/core/testing/DummyPageHolder.h

@@ -88,7 +88,7 @@ class DummyPageHolder {

InterfaceProvider* = nullptr);

Persistent<Page> m_page;

- Persistent<LocalFrame> m_frame;

+ CrossThreadPersistent<LocalFrame> m_frame;

haraken 2017/02/20 23:57:18 // TODO: This should be a Persistent. Frame must n

Persistent<FrameLoaderClient> m_frameLoaderClient;

};