third_party/WebKit/Source/core/testing/DummyPageHolder.h - Issue 2702243003: Disallow cross-thread Persistent<> read access.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/testing/DummyPageHolder.h

Issue 2702243003: Disallow cross-thread Persistent<> read access. (Closed)

Patch Set: rebase fixup Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp ('k') | third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h » ('j') | third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2013, Google Inc. All rights reserved.	2 * Copyright (c) 2013, Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 70 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
81 Document& document() const;	81 Document& document() const;

82	82

83 private:	83 private:

84 DummyPageHolder(const IntSize& initialViewSize,	84 DummyPageHolder(const IntSize& initialViewSize,

85 Page::PageClients*,	85 Page::PageClients*,

86 FrameLoaderClient*,	86 FrameLoaderClient*,

87 FrameSettingOverrideFunction settingOverrider,	87 FrameSettingOverrideFunction settingOverrider,

88 InterfaceProvider* = nullptr);	88 InterfaceProvider* = nullptr);

89	89

90 Persistent<Page> m_page;	90 Persistent<Page> m_page;

91 Persistent<LocalFrame> m_frame;	91 CrossThreadPersistent<LocalFrame> m_frame;
	haraken 2017/02/20 23:57:18 // TODO: This should be a Persistent. Frame must n // TODO: This should be a Persistent. Frame must not be accessed by non-main threads.
92	92

93 Persistent<FrameLoaderClient> m_frameLoaderClient;	93 Persistent<FrameLoaderClient> m_frameLoaderClient;

94 };	94 };

95	95

96 } // namespace blink	96 } // namespace blink

97	97

98 #endif // DummyPageHolder_h	98 #endif // DummyPageHolder_h

OLD	NEW