Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2702213003: MIPS[64]: Skip float-constant-folding tests (Closed)

Created:
3 years, 10 months ago by dusan.simicic
Modified:
3 years, 10 months ago
Reviewers:
Benedikt Meurer, ivica.bogosavljevic, ahaas, v8-mips-ports
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS[64]: Skip float-constant-folding tests qNaN and sNaN values have different binary representation on MIPS compared to ARM/x86 architectures. We are skipping these tests because we can't provide specific NaNs encodings from ARM/x86 architectures. BUG= Review-Url: https://codereview.chromium.org/2702213003 Cr-Commit-Position: refs/heads/master@{#43327} Committed: https://chromium.googlesource.com/v8/v8/+/38affafd3541cbbeb2bf13a6753516eb24b8c715

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
dusan.simicic
PTAL
3 years, 10 months ago (2017-02-20 11:37:41 UTC) #2
ivica.bogosavljevic
lgtm but you will need approval from other as well.
3 years, 10 months ago (2017-02-20 13:39:50 UTC) #4
ahaas
lgtm
3 years, 10 months ago (2017-02-20 14:08:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702213003/1
3 years, 10 months ago (2017-02-20 16:20:33 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 16:21:55 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/38affafd3541cbbeb2bf13a6753516eb24b...

Powered by Google App Engine
This is Rietveld 408576698