Gracefully handle payment app crash.

Gracefully handle payment app crash.

If the payment app crashes, the instruments callback may be invoked
multiple times, although the rest of the code expects only a single
call. Therefore, the Android payment app shim should check to make sure
that the instrument callback is being called only once.

BUG=695233
Review-Url: https://codereview.chromium.org/2702153007
Cr-Commit-Position: refs/heads/master@{#452497}
Committed: https://chromium.googlesource.com/chromium/src/+/9543088368b3b3732eb053ab7067c792a2030dd1

[please use gerrit instead, 2017-02-22 23:06:59]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[please use gerrit instead, 2017-02-22 23:07:18]

rouslan@chromium.org changed reviewers:
+ gogerald@chromium.org

[please use gerrit instead, 2017-02-22 23:07:19]

gogerald, ptal.

[commit-bot: I haz the power, 2017-02-22 23:07:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2017-02-22 23:37:03]

lgtm

[gogerald1, 2017-02-22 23:39:20]

https://codereview.chromium.org/2702153007/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
(right):

https://codereview.chromium.org/2702153007/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:171:
if (mInstrumentsCallback == null) return;
nit: might move this line below to ThreadUtils.assertOnUiThread(); to get more
exposure,

[commit-bot: I haz the power, 2017-02-22 23:57:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 23:57:19]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2017-02-23 15:07:10]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2017-02-23 15:07:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
gogerald@chromium.org
Link to the patchset: https://codereview.chromium.org/2702153007/#ps20001
(title: "Move one line down")

[commit-bot: I haz the power, 2017-02-23 15:07:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-02-23 15:07:55]

Sent to cq

https://codereview.chromium.org/2702153007/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
(right):

https://codereview.chromium.org/2702153007/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:171:
if (mInstrumentsCallback == null) return;
On 2017/02/22 23:39:20, gogerald1 wrote:
> nit: might move this line below to ThreadUtils.assertOnUiThread(); to get more
> exposure,

Done.

[commit-bot: I haz the power, 2017-02-23 15:43:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487862430352810,
"parent_rev": "ef097a7cd0861251cd05ee6adfe0293eeb56197e", "commit_rev":
"9543088368b3b3732eb053ab7067c792a2030dd1"}

[commit-bot: I haz the power, 2017-02-23 15:44:03]

Description was changed from

==========
Gracefully handle payment app crash.

If the payment app crashes, the instruments callback may be invoked
multiple times, although the rest of the code expects only a single
call. Therefore, the Android payment app shim should check to make sure
that the instrument callback is being called only once.

BUG=695233
==========

to

==========
Gracefully handle payment app crash.

If the payment app crashes, the instruments callback may be invoked
multiple times, although the rest of the code expects only a single
call. Therefore, the Android payment app shim should check to make sure
that the instrument callback is being called only once.

BUG=695233

Review-Url: https://codereview.chromium.org/2702153007
Cr-Commit-Position: refs/heads/master@{#452497}
Committed:
https://chromium.googlesource.com/chromium/src/+/9543088368b3b3732eb053ab7067...
==========

[commit-bot: I haz the power, 2017-02-23 15:44:03]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9543088368b3b3732eb053ab7067...