Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2702153005:
[SAB] Remove unreachable Uint8Clamped atomics paths (Closed)
|
Created:
3 years, 10 months ago by Dan Ehrenberg Modified:
3 years, 10 months ago Reviewers:
binji CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[SAB] Remove unreachable Uint8Clamped atomics paths
Also drive-by naming fix from the previous patch.
R=binji
Review-Url: https://codereview.chromium.org/2702153005
Cr-Commit-Position: refs/heads/master@{#43381}
Committed: https://chromium.googlesource.com/v8/v8/+/d1160fb14f767f230f4d276b4bef49f846bb7a94
Patch Set 1 #Patch Set 2 : Use the correct naming conventions #Patch Set 3 : Fix up naming #
Total comments: 2
Patch Set 4 : Fix typo in name change #Patch Set 5 : Remove redundant UNREACHABLE() #Messages
Total messages: 25 (20 generated)
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [SAB] Remove unreachable Uint8Clamped atomics paths R=binji ========== to ========== [SAB] Remove unreachable Uint8Clamped atomics paths Also drive-by naming fix from the previous patch. R=binji ==========
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...) v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/17863)
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)
lgtm % trybots https://codereview.chromium.org/2702153005/diff/2/src/builtins/builtins-share... File src/builtins/builtins-sharedarraybuffer.cc (right): https://codereview.chromium.org/2702153005/diff/2/src/builtins/builtins-share... src/builtins/builtins-sharedarraybuffer.cc:693: UNREACHABLE(); May as well just fall through to the unreachable below? That or move the unreachable from below up to the default.
The CQ bit was checked by littledan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from binji@chromium.org Link to the patchset: https://codereview.chromium.org/2702153005/#ps50001 (title: "Fix typo in name change")
The CQ bit was unchecked by littledan@chromium.org
The CQ bit was checked by littledan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from binji@chromium.org Link to the patchset: https://codereview.chromium.org/2702153005/#ps70001 (title: "Remove redundant UNREACHABLE()")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2702153005/diff/2/src/builtins/builtins-share... File src/builtins/builtins-sharedarraybuffer.cc (right): https://codereview.chromium.org/2702153005/diff/2/src/builtins/builtins-share... src/builtins/builtins-sharedarraybuffer.cc:693: UNREACHABLE(); On 2017/02/21 18:16:52, binji wrote: > May as well just fall through to the unreachable below? That or move the > unreachable from below up to the default. Done.
CQ is committing da patch.
Bot data: {"patchset_id": 70001, "attempt_start_ts": 1487779058589810,
"parent_rev": "7a21d13779e2df82b251ce74115d5b31e8bac535", "commit_rev":
"d1160fb14f767f230f4d276b4bef49f846bb7a94"}
Message was sent while issue was closed.
Description was changed from ========== [SAB] Remove unreachable Uint8Clamped atomics paths Also drive-by naming fix from the previous patch. R=binji ========== to ========== [SAB] Remove unreachable Uint8Clamped atomics paths Also drive-by naming fix from the previous patch. R=binji Review-Url: https://codereview.chromium.org/2702153005 Cr-Commit-Position: refs/heads/master@{#43381} Committed: https://chromium.googlesource.com/v8/v8/+/d1160fb14f767f230f4d276b4bef49f846b... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:70001) as https://chromium.googlesource.com/v8/v8/+/d1160fb14f767f230f4d276b4bef49f846b... |
