Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: content/public/browser/render_widget_host_view.h

Issue 2702153003: [content] Fix background color update handling in RWHVAura. (Closed)
Patch Set: Remove GetBackgroundOpaque and base impls of accessors. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/render_widget_host_view.h
diff --git a/content/public/browser/render_widget_host_view.h b/content/public/browser/render_widget_host_view.h
index 71c693bf7c3c09c90b6df776d1afe9dff015fbf2..6cf4da9d4590369b50e17658a6f08ddd46061c5c 100644
--- a/content/public/browser/render_widget_host_view.h
+++ b/content/public/browser/render_widget_host_view.h
@@ -128,13 +128,14 @@ class CONTENT_EXPORT RenderWidgetHostView {
virtual base::string16 GetSelectedText() = 0;
// Subclasses should override this method to set the background color. |color|
- // could be transparent or opaque.
+ // has to be either SK_ColorTRANSPARENT or opaque. If set to
+ // SK_ColorTRANSPARENT, the renderer's background color will be overridden to
+ // be fully transparent.
virtual void SetBackgroundColor(SkColor color) = 0;
+ virtual SkColor background_color() const = 0;
danakj 2017/02/28 17:52:31 Technically this breaks (already did) the style gu
Eric Seckler 2017/03/01 10:22:09 Yeah, I was considering doing that, but it seemed
// Convenience method to fill the background layer with the default color by
// calling |SetBackgroundColor|.
- virtual SkColor background_color() = 0;
virtual void SetBackgroundColorToDefault() = 0;
- virtual bool GetBackgroundOpaque() = 0;
// Return value indicates whether the mouse is locked successfully or not.
virtual bool LockMouse() = 0;

Powered by Google App Engine
This is Rietveld 408576698