content/browser/renderer_host/render_widget_host_view_mac_unittest.mm - Issue 2702153003: [content] Fix background color update handling in RWHVAura.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

Issue 2702153003: [content] Fix background color update handling in RWHVAura. (Closed)

Patch Set: Remove GetBackgroundOpaque and base impls of accessors. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_widget_host_unittest.cc ('K') | « content/browser/renderer_host/render_widget_host_view_mac.mm ('k') | content/public/browser/render_widget_host_view.h » ('j') | content/public/browser/render_widget_host_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm b/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

index 8761ed4da7d4442d31fb83d70d07ac1a350167cb..4c1bf4455f467fea1298699752aa3191b7ccd369 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

@@ -1125,11 +1125,13 @@ TEST_F(RenderWidgetHostViewMacTest, Background) {

new MockRenderWidgetHostImpl(&delegate, process_host, routing_id);

RenderWidgetHostViewMac* view = new RenderWidgetHostViewMac(host, false);

- EXPECT_TRUE(view->GetBackgroundOpaque());

+ EXPECT_EQ(static_cast<unsigned>(SK_AlphaOPAQUE),

+ SkColorGetA(view->background_color()));

EXPECT_TRUE([view->cocoa_view() isOpaque]);

view->SetBackgroundColor(SK_ColorTRANSPARENT);

- EXPECT_FALSE(view->GetBackgroundOpaque());

+ EXPECT_EQ(static_cast<unsigned>(SK_AlphaTRANSPARENT),

danakj 2017/02/28 17:52:31 can EXPECT_EQ(TRANSPARENT, background_color()) her

Eric Seckler 2017/03/01 10:22:09 Done.

+ SkColorGetA(view->background_color()));

EXPECT_FALSE([view->cocoa_view() isOpaque]);

const IPC::Message* set_background;

@@ -1143,7 +1145,8 @@ TEST_F(RenderWidgetHostViewMacTest, Background) {

// Try setting it back.

process_host->sink().ClearMessages();

view->SetBackgroundColor(SK_ColorWHITE);

- EXPECT_TRUE(view->GetBackgroundOpaque());

+ EXPECT_EQ(static_cast<unsigned>(SK_AlphaOPAQUE),

danakj 2017/02/28 17:52:31 and EXPECT_EQ(WHITE, background_color()) if u like

Eric Seckler 2017/03/01 10:22:09 Done.

+ SkColorGetA(view->background_color()));

EXPECT_TRUE([view->cocoa_view() isOpaque]);

set_background = process_host->sink().GetUniqueMessageMatching(

ViewMsg_SetBackgroundOpaque::ID);