Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Unified Diff: content/browser/renderer_host/render_widget_host_unittest.cc

Issue 2702153003: [content] Fix background color update handling in RWHVAura. (Closed)
Patch Set: Remove GetBackgroundOpaque and base impls of accessors. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_unittest.cc
diff --git a/content/browser/renderer_host/render_widget_host_unittest.cc b/content/browser/renderer_host/render_widget_host_unittest.cc
index 972f34021b3a5ddaaa670a1a445ef43646e6fb07..1aa6dd94fb4256a4152f5f1e274ebc58c2e3ecc1 100644
--- a/content/browser/renderer_host/render_widget_host_unittest.cc
+++ b/content/browser/renderer_host/render_widget_host_unittest.cc
@@ -887,9 +887,11 @@ TEST_F(RenderWidgetHostTest, Background) {
#endif
host_->SetView(view.get());
- EXPECT_TRUE(view->GetBackgroundOpaque());
+ EXPECT_EQ(static_cast<unsigned>(SK_AlphaOPAQUE),
+ SkColorGetA(view->background_color()));
view->SetBackgroundColor(SK_ColorTRANSPARENT);
- EXPECT_FALSE(view->GetBackgroundOpaque());
+ EXPECT_EQ(static_cast<unsigned>(SK_AlphaTRANSPARENT),
danakj 2017/02/28 17:52:31 You could just EXPECT_EQ(SK_ColorTRANSPARENT, view
Eric Seckler 2017/03/01 10:22:09 Done.
+ SkColorGetA(view->background_color()));
const IPC::Message* set_background =
process_->sink().GetUniqueMessageMatching(

Powered by Google App Engine
This is Rietveld 408576698