[DevTools] Full-size screenshots in device mode.

[DevTools] Full-size screenshots in device mode.

Based on the patch https://codereview.chromium.org/2612913002/
from Ahmet Emir Ercin (ahmetemiremir@gmail.com).

BUG=638281
Review-Url: https://codereview.chromium.org/2702113006
Cr-Commit-Position: refs/heads/master@{#452383}
Committed: https://chromium.googlesource.com/chromium/src/+/0936d31d01cc3ff8e9f46e47f807dbe05dffc59b

[dgozman, 2017-02-22 00:33:40]

Description was changed from

==========
[DevTools] Full-size screenshots in device mode.

Based on the patch https://codereview.chromium.org/2612913002/
from Ahmet Emir Ercin <ahmetemiremir@gmail.com>.

BUG=638281
==========

to

==========
[DevTools] Full-size screenshots in device mode.

Based on the patch https://codereview.chromium.org/2612913002/
from Ahmet Emir Ercin (ahmetemiremir@gmail.com).

BUG=638281
==========

[dgozman, 2017-02-22 00:33:50]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[dgozman, 2017-02-22 00:34:01]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2017-02-22 00:34:01]

Take a look please.

[commit-bot: I haz the power, 2017-02-22 00:35:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 02:37:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 02:37:31]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[pfeldman, 2017-02-23 01:09:06]

lgtm

[pfeldman, 2017-02-23 01:09:23]

Could you migrate regular screenshot to the same code?

[dgozman, 2017-02-23 01:47:06]

On 2017/02/23 01:09:23, pfeldman wrote:
> Could you migrate regular screenshot to the same code?

Yeah, I wanted to follow up with that.

[dgozman, 2017-02-23 01:47:11]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2017-02-23 01:47:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 04:00:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487814431668890, "parent_rev":
"e9bfe75886f49ffe347787389b7346dba85a313a", "commit_rev":
"0936d31d01cc3ff8e9f46e47f807dbe05dffc59b"}

[commit-bot: I haz the power, 2017-02-23 04:01:11]

Description was changed from

==========
[DevTools] Full-size screenshots in device mode.

Based on the patch https://codereview.chromium.org/2612913002/
from Ahmet Emir Ercin (ahmetemiremir@gmail.com).

BUG=638281
==========

to

==========
[DevTools] Full-size screenshots in device mode.

Based on the patch https://codereview.chromium.org/2612913002/
from Ahmet Emir Ercin (ahmetemiremir@gmail.com).

BUG=638281

Review-Url: https://codereview.chromium.org/2702113006
Cr-Commit-Position: refs/heads/master@{#452383}
Committed:
https://chromium.googlesource.com/chromium/src/+/0936d31d01cc3ff8e9f46e47f807...
==========

[commit-bot: I haz the power, 2017-02-23 04:01:12]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0936d31d01cc3ff8e9f46e47f807...

[Eric Seckler, 2017-03-13 10:41:28]

eseckler@chromium.org changed reviewers:
+ eseckler@chromium.org

[Eric Seckler, 2017-03-13 10:41:29]

https://codereview.chromium.org/2702113006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp (right):

https://codereview.chromium.org/2702113006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp:873:
*outContentSize = protocol::DOM::Rect::create()
FWIW, do we actually need this? Could we not get the same value by querying
document.scrollingElement.scrollWidth/Height via js?

[dgozman, 2017-03-13 15:04:04]

https://codereview.chromium.org/2702113006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp (right):

https://codereview.chromium.org/2702113006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp:873:
*outContentSize = protocol::DOM::Rect::create()
On 2017/03/13 10:41:28, Eric Seckler wrote:
> FWIW, do we actually need this? Could we not get the same value by querying
> document.scrollingElement.scrollWidth/Height via js?

We could! But since we already have getLayoutMetrics, I feel like exposing this
information does not hurt.