win: Unconditionally download clang during runhooks

win: Unconditionally download clang during runhooks

This adds an additional ~50MB download to runhooks every few weeks.
The motivation for doing this is two-fold:

1. It makes it easier for people to try out clang on Windows
2. libyuv currently uses relatively unoptimized C-only functions
   on 64-bit Windows due to cl not supporting inline assembly.
   clang-cl does, and building libyuv with clang-cl speeds up
   some libyuv conversion functions to take 0.4ms instead of 2ms
   per frame, so we want to try and build just libyuv with clang
   even in MSVC builds.

BUG=692600, 82385
Review-Url: https://codereview.chromium.org/2702113005
Cr-Commit-Position: refs/heads/master@{#451827}
Committed: https://chromium.googlesource.com/chromium/src/+/43c2826bfce0d245221aab0183a0e9f3f883a7f4

[Nico, 2017-02-21 17:25:15]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[Nico, 2017-02-21 17:25:55]

thakis@chromium.org changed reviewers:
+ scottmg@chromium.org

[Nico, 2017-02-21 17:25:56]

scottmg: How silly does 2 sound? See linked bug for some more details. gn does
make this pretty easy.

[commit-bot: I haz the power, 2017-02-21 17:25:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hans, 2017-02-21 17:47:06]

https://codereview.chromium.org/2702113005/diff/1/tools/clang/scripts/update.py
File tools/clang/scripts/update.py (left):

https://codereview.chromium.org/2702113005/diff/1/tools/clang/scripts/update....
tools/clang/scripts/update.py:878: return 0
Nice!

[scottmg, 2017-02-21 17:56:56]

Seems fine to me. The libyuv part of it makes me a bit nervous, but it's not
unprecedented since we used to do all sorts of crazy things before MSVC could
compile ffmpeg.

lgtm

(Semi-apropos, is this where I'd need to change to add a libclang_rt.builtins
lib?)

[Nico, 2017-02-21 18:09:48]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2017-02-21 18:09:49]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-02-21 18:10:22]

On 2017/02/21 17:56:56, scottmg wrote:
> Seems fine to me. The libyuv part of it makes me a bit nervous, but it's not
> unprecedented since we used to do all sorts of crazy things before MSVC could
> compile ffmpeg.
> 
> lgtm
> 
> (Semi-apropos, is this where I'd need to change to add a libclang_rt.builtins
> lib?)

That'd go into package.py next to this file probably.

[commit-bot: I haz the power, 2017-02-21 18:10:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 20:10:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487700589080610, "parent_rev":
"875d1fb2901159381fb28c278148432c8da568b5", "commit_rev":
"43c2826bfce0d245221aab0183a0e9f3f883a7f4"}

[commit-bot: I haz the power, 2017-02-21 20:12:14]

Description was changed from

==========
win: Unconditionally download clang during runhooks

This adds an additional ~50MB download to runhooks every few weeks.
The motivation for doing this is two-fold:

1. It makes it easier for people to try out clang on Windows
2. libyuv currently uses relatively unoptimized C-only functions
   on 64-bit Windows due to cl not supporting inline assembly.
   clang-cl does, and building libyuv with clang-cl speeds up
   some libyuv conversion functions to take 0.4ms instead of 2ms
   per frame, so we want to try and build just libyuv with clang
   even in MSVC builds.

BUG=692600,82385
==========

to

==========
win: Unconditionally download clang during runhooks

This adds an additional ~50MB download to runhooks every few weeks.
The motivation for doing this is two-fold:

1. It makes it easier for people to try out clang on Windows
2. libyuv currently uses relatively unoptimized C-only functions
   on 64-bit Windows due to cl not supporting inline assembly.
   clang-cl does, and building libyuv with clang-cl speeds up
   some libyuv conversion functions to take 0.4ms instead of 2ms
   per frame, so we want to try and build just libyuv with clang
   even in MSVC builds.

BUG=692600,82385

Review-Url: https://codereview.chromium.org/2702113005
Cr-Commit-Position: refs/heads/master@{#451827}
Committed:
https://chromium.googlesource.com/chromium/src/+/43c2826bfce0d245221aab0183a0...
==========

[commit-bot: I haz the power, 2017-02-21 20:12:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/43c2826bfce0d245221aab0183a0...