Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2702113003: Move tests for sendBeacon to a separate dedicated directory for clearer ownership (Closed)

Created:
3 years, 10 months ago by tyoshino (SeeGerritForStatus)
Modified:
3 years, 10 months ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move tests for sendBeacon to a separate dedicated directory for clearer ownership Not only because of the ownership clarification, but it's just good to have a better home for them since they're closer to XHR and Fetch API. It's not so reasonable to place them in navigation/ just because they belongs to window.navigator. The virtual test virtual/stable/http/tests/navigation/ is kept for a different reason. Moved redirection-respond.php to http/tests/resources as it's not specific to the tests under http/tests/navigation/ BUG=682571, 619662, 490015, 694958 Review-Url: https://codereview.chromium.org/2702113003 Cr-Commit-Position: refs/heads/master@{#452408} Committed: https://chromium.googlesource.com/chromium/src/+/8a75af1cd30519bd7205f0d9129eb8db8f29c48d

Patch Set 1 : a #

Patch Set 2 : a #

Patch Set 3 : a #

Patch Set 4 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -706 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +5 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/beacon-allowance.html View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/beacon-allowance-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/beacon-blob-with-non-simple-type.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cookie.html View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cookie-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-blob.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-credentials.html View 1 chunk +0 lines, -123 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin.https.html View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin.https-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/beacon-detached-no-crash.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/beacon-detached-no-crash-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/beacon-same-origin.html View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/beacon-same-origin-expected.txt View 1 chunk +0 lines, -53 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/navigation/post-301-response.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/navigation/post-302-response.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/navigation/post-303-response.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/navigation/post-307-response.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/resources/check-beacon.php View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/resources/redirection-response.php View 1 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/resources/save-beacon.php View 1 chunk +0 lines, -40 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/resources/redirection-response.php View 1 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/connect-src-beacon-redirect-to-blocked.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/connect-src-beacon-redirect-to-blocked-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-allowance.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-allowance-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-blob-with-non-simple-type.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cookie.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cookie-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-redirect.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-redirect-blob.html View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-redirect-credentials.html View 1 4 chunks +4 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-redirect-expected.txt View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin.https.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin.https-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-detached-no-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-detached-no-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-same-origin.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-same-origin-expected.txt View 1 5 chunks +8 lines, -8 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/sendbeacon/resources/check-beacon.php View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/sendbeacon/resources/save-beacon.php View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/navigation/README.txt View 1 chunk +2 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/stable/http/tests/navigation/beacon-cross-origin-redirect-blob-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/stable/http/tests/sendbeacon/README.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/stable/http/tests/sendbeacon/beacon-cross-origin-redirect-blob-expected.txt View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 36 (32 generated)
tyoshino (SeeGerritForStatus)
3 years, 10 months ago (2017-02-22 13:08:07 UTC) #26
yhirano
lgtm
3 years, 10 months ago (2017-02-23 05:16:46 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702113003/180001
3 years, 10 months ago (2017-02-23 05:34:15 UTC) #33
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 05:40:03 UTC) #36
Message was sent while issue was closed.
Committed patchset #4 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/8a75af1cd30519bd7205f0d9129e...

Powered by Google App Engine
This is Rietveld 408576698