Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 2702093002: Consistent CopyFromSurface() API, consolidated to RWHV (Closed)
Patch Set: REBASE Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.h
diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h
index dc3c6e7052ce25046361bde0d570bc6141b02f41..8df14f6e0cb5f6361b70086aa15a79d5bbfd5aa6 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.h
+++ b/content/browser/renderer_host/render_widget_host_view_android.h
@@ -92,13 +92,17 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid
gfx::NativeViewAccessible GetNativeViewAccessible() override;
void Focus() override;
bool HasFocus() const override;
- bool IsSurfaceAvailableForCopy() const override;
void Show() override;
void Hide() override;
bool IsShowing() override;
gfx::Rect GetViewBounds() const override;
gfx::Size GetVisibleViewportSize() const override;
gfx::Size GetPhysicalBackingSize() const override;
+ bool IsSurfaceAvailableForCopy() const override;
+ void CopyFromSurface(const gfx::Rect& src_rect,
+ const gfx::Size& output_size,
+ const ReadbackRequestCallback& callback,
+ const SkColorType color_type) override;
bool DoBrowserControlsShrinkBlinkSize() const override;
float GetTopControlsHeight() const override;
float GetBottomControlsHeight() const override;
@@ -112,16 +116,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid
void SetTooltipText(const base::string16& tooltip_text) override;
bool HasAcceleratedSurface(const gfx::Size& desired_size) override;
void SetBackgroundColor(SkColor color) override;
- void CopyFromCompositingSurface(
- const gfx::Rect& src_subrect,
- const gfx::Size& dst_size,
- const ReadbackRequestCallback& callback,
- const SkColorType preferred_color_type) override;
- void CopyFromCompositingSurfaceToVideoFrame(
- const gfx::Rect& src_subrect,
- const scoped_refptr<media::VideoFrame>& target,
- const base::Callback<void(const gfx::Rect&, bool)>& callback) override;
- bool CanCopyToVideoFrame() const override;
gfx::Rect GetBoundsInRootWindow() override;
void ProcessAckedTouchEvent(const TouchEventWithLatencyInfo& touch,
InputEventAckState ack_result) override;

Powered by Google App Engine
This is Rietveld 408576698