Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2702093002: Consistent CopyFromSurface() API, consolidated to RWHV (Closed)
Patch Set: REBASE Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 5b47fbad932eeeef7c367c4b486ad33fdcb5ad88..33a867306230621b26aa2605b0e1fe06d830960a 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -550,8 +550,7 @@ void RenderWidgetHostViewAndroid::GetScaledContentBitmap(
gfx::ScaleToCeiledSize(src_subrect.size(), scale / device_scale_factor));
src_subrect = gfx::ConvertRectToDIP(device_scale_factor, src_subrect);
- CopyFromCompositingSurface(src_subrect, dst_size, result_callback,
- preferred_color_type);
+ CopyFromSurface(src_subrect, dst_size, result_callback, preferred_color_type);
}
bool RenderWidgetHostViewAndroid::HasValidFrame() const {
@@ -919,12 +918,12 @@ void RenderWidgetHostViewAndroid::SetBackgroundColor(SkColor color) {
UpdateBackgroundColor(color);
}
-void RenderWidgetHostViewAndroid::CopyFromCompositingSurface(
+void RenderWidgetHostViewAndroid::CopyFromSurface(
const gfx::Rect& src_subrect,
const gfx::Size& dst_size,
const ReadbackRequestCallback& callback,
const SkColorType preferred_color_type) {
- TRACE_EVENT0("cc", "RenderWidgetHostViewAndroid::CopyFromCompositingSurface");
+ TRACE_EVENT0("cc", "RenderWidgetHostViewAndroid::CopyFromSurface");
if (!host_ || !IsSurfaceAvailableForCopy()) {
callback.Run(SkBitmap(), READBACK_SURFACE_UNAVAILABLE);
return;
@@ -964,18 +963,6 @@ void RenderWidgetHostViewAndroid::CopyFromCompositingSurface(
preferred_color_type, start_time, callback, readback_lock));
}
-void RenderWidgetHostViewAndroid::CopyFromCompositingSurfaceToVideoFrame(
- const gfx::Rect& src_subrect,
- const scoped_refptr<media::VideoFrame>& target,
- const base::Callback<void(const gfx::Rect&, bool)>& callback) {
- NOTIMPLEMENTED();
- callback.Run(gfx::Rect(), false);
-}
-
-bool RenderWidgetHostViewAndroid::CanCopyToVideoFrame() const {
- return false;
-}
-
void RenderWidgetHostViewAndroid::ShowDisambiguationPopup(
const gfx::Rect& rect_pixels, const SkBitmap& zoomed_bitmap) {
if (!content_view_core_)

Powered by Google App Engine
This is Rietveld 408576698