Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2702033002: [ScreenOrientation] Fire pending lock request when we found it has failed.

Created:
3 years, 10 months ago by leonhsl(Using Gerrit)
Modified:
3 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-screen-orientation_chromium.org, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ScreenOrientation] Fire pending lock request when we found it has failed. This CL fires the pending lock request when we found the screen orientation delegate has failed to lock orientation to what we wanted. Two scenarios for this: - On Android, after screen orientation delegate started lock, later we got an asynchronous orientation change notification but we found current orientation value is not what we wanted to lock to. - On platforms other than Android, we do expect screen orientation delegate to execute lock synchronously, but after lock we found that current orientation is not what we wanted to lock to. BUG=678545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -4 lines) Patch
M content/browser/screen_orientation/screen_orientation_provider.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/screen_orientation/screen_orientation_provider.cc View 4 chunks +23 lines, -3 lines 0 comments Download
M content/browser/screen_orientation/screen_orientation_provider_unittest.cc View 7 chunks +47 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (24 generated)
leonhsl(Using Gerrit)
3 years, 10 months ago (2017-02-18 16:45:45 UTC) #19
PTAL, Thanks.

Powered by Google App Engine
This is Rietveld 408576698