Gtk3: Fix tab border color and --secondary-ui-md colors

Gtk3: Fix tab border color and --secondary-ui-md colors

This CL:
* Calculates an appropriate alpha for COLOR_TOOLBAR_TOP_SEPARATOR
  so that the border between (a tab and the frame) and (a tab and
  the toolbar) are both reasonable.
* Fixes FocusedBorderColor and ProminentButtonColor when using
  --secondary-ui-md.
* Switches GtkEntry for GtkTextView where possible.
  * Also updates the results table to reference the calculated
    TextField background colors instead of using GetBgColor directly.
* Adds GtkTreeView#treeview to tree view cells.

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2701923002
Cr-Commit-Position: refs/heads/master@{#451901}
Committed: https://chromium.googlesource.com/chromium/src/+/a313bd2dbe1576252dff87250f0d2b20434a3b9b

[Tom (Use chromium acct), 2017-02-17 21:11:23]

Patchset #1 (id:1) has been deleted

[Tom (Use chromium acct), 2017-02-18 01:39:24]

Patchset #1 (id:20001) has been deleted

[Tom (Use chromium acct), 2017-02-21 19:42:30]

Description was changed from

==========
Gtk3: Final fixes

BUG=132847
R=erg@chromium.org
==========

to

==========
Gtk3: Fix tab border color and --secondary-ui-md colors

This CL:
* Calculates an appropriate alpha for COLOR_TOOLBAR_TOP_SEPARATOR
  so that the border between (a tab and the frame) and (a tab and
  the toolbar) are both reasonable.
* Fixes FocusedBorderColor and ProminentButtonColor when using
  --secondary-ui-md.
* Switches GtkEntry for GtkTextView where possible.
  * Also updates the results table to reference the calculated
    TextField background colors instead of using GetBgColor directly.

BUG=132847
R=erg@chromium.org
==========

[Tom (Use chromium acct), 2017-02-21 19:46:11]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 19:47:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom (Use chromium acct), 2017-02-21 19:52:41]

Description was changed from

==========
Gtk3: Fix tab border color and --secondary-ui-md colors

This CL:
* Calculates an appropriate alpha for COLOR_TOOLBAR_TOP_SEPARATOR
  so that the border between (a tab and the frame) and (a tab and
  the toolbar) are both reasonable.
* Fixes FocusedBorderColor and ProminentButtonColor when using
  --secondary-ui-md.
* Switches GtkEntry for GtkTextView where possible.
  * Also updates the results table to reference the calculated
    TextField background colors instead of using GetBgColor directly.

BUG=132847
R=erg@chromium.org
==========

to

==========
Gtk3: Fix tab border color and --secondary-ui-md colors

This CL:
* Calculates an appropriate alpha for COLOR_TOOLBAR_TOP_SEPARATOR
  so that the border between (a tab and the frame) and (a tab and
  the toolbar) are both reasonable.
* Fixes FocusedBorderColor and ProminentButtonColor when using
  --secondary-ui-md.
* Switches GtkEntry for GtkTextView where possible.
  * Also updates the results table to reference the calculated
    TextField background colors instead of using GetBgColor directly.
* Adds GtkTreeView#treeview to tree view selectors.

BUG=132847
R=erg@chromium.org
==========

[Tom (Use chromium acct), 2017-02-21 19:52:47]

Patchset #2 (id:60001) has been deleted

[Tom (Use chromium acct), 2017-02-21 19:53:09]

Description was changed from

==========
Gtk3: Fix tab border color and --secondary-ui-md colors

This CL:
* Calculates an appropriate alpha for COLOR_TOOLBAR_TOP_SEPARATOR
  so that the border between (a tab and the frame) and (a tab and
  the toolbar) are both reasonable.
* Fixes FocusedBorderColor and ProminentButtonColor when using
  --secondary-ui-md.
* Switches GtkEntry for GtkTextView where possible.
  * Also updates the results table to reference the calculated
    TextField background colors instead of using GetBgColor directly.
* Adds GtkTreeView#treeview to tree view selectors.

BUG=132847
R=erg@chromium.org
==========

to

==========
Gtk3: Fix tab border color and --secondary-ui-md colors

This CL:
* Calculates an appropriate alpha for COLOR_TOOLBAR_TOP_SEPARATOR
  so that the border between (a tab and the frame) and (a tab and
  the toolbar) are both reasonable.
* Fixes FocusedBorderColor and ProminentButtonColor when using
  --secondary-ui-md.
* Switches GtkEntry for GtkTextView where possible.
  * Also updates the results table to reference the calculated
    TextField background colors instead of using GetBgColor directly.
* Adds GtkTreeView#treeview to tree view cells.

BUG=132847
R=erg@chromium.org
==========

[commit-bot: I haz the power, 2017-02-21 19:55:07]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Tom (Use chromium acct), 2017-02-21 20:03:47]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[Tom (Use chromium acct), 2017-02-21 20:04:12]

Patchset #2 (id:80001) has been deleted

[commit-bot: I haz the power, 2017-02-21 20:05:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-02-21 20:24:00]

lgtm

https://codereview.chromium.org/2701923002/diff/100001/chrome/browser/ui/libg...
File chrome/browser/ui/libgtkui/gtk_ui.cc (right):

https://codereview.chromium.org/2701923002/diff/100001/chrome/browser/ui/libg...
chrome/browser/ui/libgtkui/gtk_ui.cc:895: auto get_toolbar_top_separator =
[](SkColor header_fg, SkColor header_bg,
prefer a named function in an anonymous namespace at the top of the file to
using lambdas like this.

[Tom (Use chromium acct), 2017-02-21 20:24:55]

The CQ bit was unchecked by thomasanderson@google.com

[Tom (Use chromium acct), 2017-02-21 20:29:04]

https://codereview.chromium.org/2701923002/diff/100001/chrome/browser/ui/libg...
File chrome/browser/ui/libgtkui/gtk_ui.cc (right):

https://codereview.chromium.org/2701923002/diff/100001/chrome/browser/ui/libg...
chrome/browser/ui/libgtkui/gtk_ui.cc:895: auto get_toolbar_top_separator =
[](SkColor header_fg, SkColor header_bg,
On 2017/02/21 20:24:00, Elliot Glaysher wrote:
> prefer a named function in an anonymous namespace at the top of the file to
> using lambdas like this.

Done.

[Tom (Use chromium acct), 2017-02-21 20:29:08]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2017-02-21 20:29:08]

The patchset sent to the CQ was uploaded after l-g-t-m from erg@chromium.org
Link to the patchset: https://codereview.chromium.org/2701923002/#ps120001
(title: "Move lambda to function in anonymous namespace")

[commit-bot: I haz the power, 2017-02-21 20:30:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 22:35:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 22:35:23]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[Tom (Use chromium acct), 2017-02-22 01:15:55]

On 2017/02/21 22:35:23, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
> URL)
>   chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
> (JOB_TIMED_OUT, no build URL)
>   linux_chromium_asan_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT,
> no build URL)
>   linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
> build URL)

The last trybot (linux_chromium_rel_ng) has an ETA of 2+ hours, so I'm adding
NOTRY=true so I can land this now and get the try jobs for the GTK3 switch
running.

FYI linux_chromium_asan_rel_ng already passed, so it's unlikely
linux_chromium_rel_ng would fail

[Tom (Use chromium acct), 2017-02-22 01:16:06]

Description was changed from

==========
Gtk3: Fix tab border color and --secondary-ui-md colors

This CL:
* Calculates an appropriate alpha for COLOR_TOOLBAR_TOP_SEPARATOR
  so that the border between (a tab and the frame) and (a tab and
  the toolbar) are both reasonable.
* Fixes FocusedBorderColor and ProminentButtonColor when using
  --secondary-ui-md.
* Switches GtkEntry for GtkTextView where possible.
  * Also updates the results table to reference the calculated
    TextField background colors instead of using GetBgColor directly.
* Adds GtkTreeView#treeview to tree view cells.

BUG=132847
R=erg@chromium.org
==========

to

==========
Gtk3: Fix tab border color and --secondary-ui-md colors

This CL:
* Calculates an appropriate alpha for COLOR_TOOLBAR_TOP_SEPARATOR
  so that the border between (a tab and the frame) and (a tab and
  the toolbar) are both reasonable.
* Fixes FocusedBorderColor and ProminentButtonColor when using
  --secondary-ui-md.
* Switches GtkEntry for GtkTextView where possible.
  * Also updates the results table to reference the calculated
    TextField background colors instead of using GetBgColor directly.
* Adds GtkTreeView#treeview to tree view cells.

BUG=132847
R=erg@chromium.org
NOTRY=true
==========

[Tom (Use chromium acct), 2017-02-22 01:16:11]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-02-22 01:17:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 03:21:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 03:21:32]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[Tom (Use chromium acct), 2017-02-22 03:28:13]

Description was changed from

==========
Gtk3: Fix tab border color and --secondary-ui-md colors

This CL:
* Calculates an appropriate alpha for COLOR_TOOLBAR_TOP_SEPARATOR
  so that the border between (a tab and the frame) and (a tab and
  the toolbar) are both reasonable.
* Fixes FocusedBorderColor and ProminentButtonColor when using
  --secondary-ui-md.
* Switches GtkEntry for GtkTextView where possible.
  * Also updates the results table to reference the calculated
    TextField background colors instead of using GetBgColor directly.
* Adds GtkTreeView#treeview to tree view cells.

BUG=132847
R=erg@chromium.org
NOTRY=true
==========

to

==========
Gtk3: Fix tab border color and --secondary-ui-md colors

This CL:
* Calculates an appropriate alpha for COLOR_TOOLBAR_TOP_SEPARATOR
  so that the border between (a tab and the frame) and (a tab and
  the toolbar) are both reasonable.
* Fixes FocusedBorderColor and ProminentButtonColor when using
  --secondary-ui-md.
* Switches GtkEntry for GtkTextView where possible.
  * Also updates the results table to reference the calculated
    TextField background colors instead of using GetBgColor directly.
* Adds GtkTreeView#treeview to tree view cells.

BUG=132847
R=erg@chromium.org
==========

[Tom (Use chromium acct), 2017-02-22 06:25:51]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-02-22 06:27:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 06:34:57]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1487744751100410,
"parent_rev": "c5f5997a844d23d27adbef98d04dd6e1f4a10084", "commit_rev":
"a313bd2dbe1576252dff87250f0d2b20434a3b9b"}

[commit-bot: I haz the power, 2017-02-22 06:35:52]

Description was changed from

==========
Gtk3: Fix tab border color and --secondary-ui-md colors

This CL:
* Calculates an appropriate alpha for COLOR_TOOLBAR_TOP_SEPARATOR
  so that the border between (a tab and the frame) and (a tab and
  the toolbar) are both reasonable.
* Fixes FocusedBorderColor and ProminentButtonColor when using
  --secondary-ui-md.
* Switches GtkEntry for GtkTextView where possible.
  * Also updates the results table to reference the calculated
    TextField background colors instead of using GetBgColor directly.
* Adds GtkTreeView#treeview to tree view cells.

BUG=132847
R=erg@chromium.org
==========

to

==========
Gtk3: Fix tab border color and --secondary-ui-md colors

This CL:
* Calculates an appropriate alpha for COLOR_TOOLBAR_TOP_SEPARATOR
  so that the border between (a tab and the frame) and (a tab and
  the toolbar) are both reasonable.
* Fixes FocusedBorderColor and ProminentButtonColor when using
  --secondary-ui-md.
* Switches GtkEntry for GtkTextView where possible.
  * Also updates the results table to reference the calculated
    TextField background colors instead of using GetBgColor directly.
* Adds GtkTreeView#treeview to tree view cells.

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2701923002
Cr-Commit-Position: refs/heads/master@{#451901}
Committed:
https://chromium.googlesource.com/chromium/src/+/a313bd2dbe1576252dff87250f0d...
==========

[commit-bot: I haz the power, 2017-02-22 06:35:53]

Committed patchset #3 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/a313bd2dbe1576252dff87250f0d...