chrome/browser/extensions/url_request_util.cc - Issue 270183002: Move IsStringUTF8/ASCII to base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/url_request_util.cc

Issue 270183002: Move IsStringUTF8/ASCII to base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more minor nit Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/url_request_util.cc

diff --git a/chrome/browser/extensions/url_request_util.cc b/chrome/browser/extensions/url_request_util.cc

index 82dd7f7c132f869f074ab7a2672d1737e5491efa..8df596c6045a0d5b874dfbf1ab9ddd43b9777b8d 100644

--- a/chrome/browser/extensions/url_request_util.cc

+++ b/chrome/browser/extensions/url_request_util.cc

@@ -107,7 +107,7 @@ class URLRequestResourceBundleJob : public net::URLRequestSimpleJob {

if (StartsWithASCII(*read_mime_type, "text/", false)) {

// All of our HTML files should be UTF-8 and for other resource types

// (like images), charset doesn't matter.

- DCHECK(IsStringUTF8(*data));

+ DCHECK(base::IsStringUTF8(*data));

*charset = "utf-8";

}

int result = read_result ? net::OK : net::ERR_INVALID_URL;