chrome/browser/extensions/extension_garbage_collector.cc - Issue 270183002: Move IsStringUTF8/ASCII to base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_garbage_collector.cc

Issue 270183002: Move IsStringUTF8/ASCII to base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more minor nit Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_garbage_collector.cc

diff --git a/chrome/browser/extensions/extension_garbage_collector.cc b/chrome/browser/extensions/extension_garbage_collector.cc

index df33b09902e305dfc18c67462c47232b1d968d0e..54198736b48fc462236311bfbb357a91de641e14 100644

--- a/chrome/browser/extensions/extension_garbage_collector.cc

+++ b/chrome/browser/extensions/extension_garbage_collector.cc

@@ -54,7 +54,7 @@ void CheckExtensionDirectory(const base::FilePath& path,

// Parse directory name as a potential extension ID.

std::string extension_id;

- if (IsStringASCII(basename.value())) {

+ if (base::IsStringASCII(basename.value())) {

extension_id = base::UTF16ToASCII(basename.LossyDisplayName());

if (!Extension::IdIsValid(extension_id))

extension_id.clear();