chrome/browser/download/download_extensions.cc - Issue 270183002: Move IsStringUTF8/ASCII to base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_extensions.cc

Issue 270183002: Move IsStringUTF8/ASCII to base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more minor nit Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_extensions.cc

diff --git a/chrome/browser/download/download_extensions.cc b/chrome/browser/download/download_extensions.cc

index 4d36aa0a54185a9256f34ef9acf9232cafcc50c5..75ebb01006b6655817b6ba4ebd069d0cd7fdcc17 100644

--- a/chrome/browser/download/download_extensions.cc

+++ b/chrome/browser/download/download_extensions.cc

@@ -209,7 +209,7 @@ DownloadDangerLevel GetFileDangerLevel(const base::FilePath& path) {

base::FilePath::StringType extension(path.FinalExtension());

if (extension.empty())

return NOT_DANGEROUS;

- if (!IsStringASCII(extension))

+ if (!base::IsStringASCII(extension))

return NOT_DANGEROUS;

#if defined(OS_WIN)

std::string ascii_extension = base::UTF16ToASCII(extension);