chrome/browser/chromeos/system/syslogs_provider.cc - Issue 270183002: Move IsStringUTF8/ASCII to base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/system/syslogs_provider.cc

Issue 270183002: Move IsStringUTF8/ASCII to base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more minor nit Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/system/syslogs_provider.cc

diff --git a/chrome/browser/chromeos/system/syslogs_provider.cc b/chrome/browser/chromeos/system/syslogs_provider.cc

index b30212b62c356b9a0abfc75011f66b139a763285..92feef778f0a85345cb83f44e6374cca52bebbcf 100644

--- a/chrome/browser/chromeos/system/syslogs_provider.cc

+++ b/chrome/browser/chromeos/system/syslogs_provider.cc

@@ -158,7 +158,7 @@ LogDictionaryType* GetSystemLogs(base::FilePath* zip_file_name,

base::TrimWhitespaceASCII(key, base::TRIM_ALL, &key);

if (!key.empty()) {

std::string value = ReadValue(&data);

- if (IsStringUTF8(value)) {

+ if (base::IsStringUTF8(value)) {

base::TrimWhitespaceASCII(value, base::TRIM_ALL, &value);

if (value.empty())

(*logs)[key] = kEmptyLogEntry;