Remove usages of HeapProfiler.finishHeapSnapshot from pyautolib

Remove usages of HeapProfiler.finishHeapSnapshot from pyautolib

HeapProfiler.finishHeapSnapshot is being removed from the protocol (see https://codereview.chromium.org/27000005/). This change makes RemoteInspectorClient use the same mechanism as in DevTools front-end.

BUG=306475
R=dennisjeffrey@chromium.org, marja@chromium.org
TBR=kkania@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228650

[loislo, 2013-10-11 12:47:24]

sgtm

[dennis_jeffrey, 2013-10-11 17:07:09]

LGTM

[commit-bot: I haz the power, 2013-10-12 17:41:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yurys@chromium.org/27018002/1

[commit-bot: I haz the power, 2013-10-12 17:56:00]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[yurys, 2013-10-13 06:15:31]

Ken, can you do OWNER's review please since dennisjeffrey is not in the OWNERS
file anymore.

[marja, 2013-10-14 10:09:32]

lgtm

fyi, there's another place where heap snapshots are taken (we're trying to get
rid of remote_inspector_client), it's
tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py (see
https://codereview.chromium.org/22923013 )

[yurys, 2013-10-14 10:14:10]

On 2013/10/14 10:09:32, marja wrote:
> lgtm
> 
> fyi, there's another place where heap snapshots are taken (we're trying to get
> rid of remote_inspector_client), it's
> tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py (see
> https://codereview.chromium.org/22923013 )

OK, can you please remove HeapProfiler.finishHeapSnapshot usages there?

[marja, 2013-10-14 13:20:01]

On 2013/10/14 10:14:10, Yury Semikhatsky wrote:
> On 2013/10/14 10:09:32, marja wrote:
> > lgtm
> > 
> > fyi, there's another place where heap snapshots are taken (we're trying to
get
> > rid of remote_inspector_client), it's
> > tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py (see
> > https://codereview.chromium.org/22923013 )
> 
> OK, can you please remove HeapProfiler.finishHeapSnapshot usages there?

I'll put it to my TODO.

[commit-bot: I haz the power, 2013-10-14 16:01:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yurys@chromium.org/27018002/1

[commit-bot: I haz the power, 2013-10-14 16:17:21]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[yurys, 2013-10-15 07:56:57]

Committed patchset #1 manually as r228650 (presubmit successful).