DevTools: run user callback inside promise for promisified domains

DevTools: run user callback inside promise for promisified domains

This patch runs userCallback inside a promise. This results in errors
not being swallowed, and the promise to always resolve/reject but never
to get stuck.

As a result, the StylesSidebarPane will not die permanently
once an error happens during handling the protocol response.

BUG=681492
R=pfeldman

Review-Url: https://codereview.chromium.org/2701763002
Cr-Commit-Position: refs/heads/master@{#451416}
Committed: https://chromium.googlesource.com/chromium/src/+/5ac15460e9aab7b68f858f911b2e4ced8e0aadaa

[lushnikov, 2017-02-16 22:36:56]

please, take a look

[pfeldman, 2017-02-16 22:43:02]

https://codereview.chromium.org/2701763002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js
(right):

https://codereview.chromium.org/2701763002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js:604:
return Promise.reject(new Error(errorMessage));
You aren't calling it here, are you?

https://codereview.chromium.org/2701763002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js:624:
function runUserCallback() {
You are changing the order of callback and promise resolution, while clients
rely on it.

[pfeldman, 2017-02-16 22:48:50]

lgtm % error callback upon invalid params.

[lushnikov, 2017-02-16 23:11:36]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-02-16 23:11:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2701763002/#ps20001
(title: "call user callback when errored in parsing arguments")

[commit-bot: I haz the power, 2017-02-16 23:13:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2017-02-17 00:05:33]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2017-02-17 00:06:41]

Description was changed from

==========
DevTools: run user callback inside promise for promisified domains

This patch runs userCallback inside a promise. This results in errors
not being swallowed, and the promise to always resolve/reject but never
to get stuck.

BUG=none
R=pfeldman
==========

to

==========
DevTools: run user callback inside promise for promisified domains

This patch runs userCallback inside a promise. This results in errors
not being swallowed, and the promise to always resolve/reject but never
to get stuck.

As a result, the StylesSidebarPane will not die permanently
once an error happens during handling the protocol response.

BUG=681492
R=pfeldman
==========

[lushnikov, 2017-02-17 00:06:45]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-02-17 00:09:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 01:25:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 01:25:54]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lushnikov, 2017-02-17 01:57:02]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-02-17 01:58:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 03:14:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 03:14:03]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lushnikov, 2017-02-17 03:58:25]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-02-17 03:59:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 04:04:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 04:04:24]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[lushnikov, 2017-02-17 19:33:40]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-02-17 19:33:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2701763002/#ps40001
(title: "rebaseline test")

[commit-bot: I haz the power, 2017-02-17 19:34:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 20:38:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 20:38:39]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[lushnikov, 2017-02-17 22:15:53]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-02-17 22:17:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 00:20:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 00:20:57]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[lushnikov, 2017-02-18 03:03:39]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-02-18 03:04:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 04:10:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487387019595860,
"parent_rev": "d69da860fbe6e4b6a0ad3f4a7a79f816a2adfd75", "commit_rev":
"5ac15460e9aab7b68f858f911b2e4ced8e0aadaa"}

[commit-bot: I haz the power, 2017-02-18 04:12:12]

Description was changed from

==========
DevTools: run user callback inside promise for promisified domains

This patch runs userCallback inside a promise. This results in errors
not being swallowed, and the promise to always resolve/reject but never
to get stuck.

As a result, the StylesSidebarPane will not die permanently
once an error happens during handling the protocol response.

BUG=681492
R=pfeldman
==========

to

==========
DevTools: run user callback inside promise for promisified domains

This patch runs userCallback inside a promise. This results in errors
not being swallowed, and the promise to always resolve/reject but never
to get stuck.

As a result, the StylesSidebarPane will not die permanently
once an error happens during handling the protocol response.

BUG=681492
R=pfeldman

Review-Url: https://codereview.chromium.org/2701763002
Cr-Commit-Position: refs/heads/master@{#451416}
Committed:
https://chromium.googlesource.com/chromium/src/+/5ac15460e9aab7b68f858f911b2e...
==========

[commit-bot: I haz the power, 2017-02-18 04:12:14]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5ac15460e9aab7b68f858f911b2e...