Don't let creating Google accounts on the Active Directory devices.

Don't let creating Google accounts on the Active Directory devices.

BUG=676297
TEST=ExistingUserControllerActiveDirectoryTest.*
TBR=grt@chromium.org

Review-Url: https://codereview.chromium.org/2701753004
Cr-Commit-Position: refs/heads/master@{#451308}
Committed: https://chromium.googlesource.com/chromium/src/+/44243c3dbc42d90b31f410ba8a778105dc11da6b

[Roman Sorokin (ftl), 2017-02-17 12:41:43]

rsorokin@chromium.org changed reviewers:
+ achuith@chromium.org

[Roman Sorokin (ftl), 2017-02-17 12:41:44]

Hey Achuith, could you please take a look? Thanks!

[Roman Sorokin (ftl), 2017-02-17 12:41:57]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 12:42:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[achuithb, 2017-02-17 13:03:49]

lgtm

https://codereview.chromium.org/2701753004/diff/1/chrome/app/chromeos_strings...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2701753004/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:5493: Sorry, Microsoft® Active Directory®
accounts only are allowed on the device.
Should probably get a PM to vet this.

Only Microsoft Active Directory accounts are allowed on this device.

https://codereview.chromium.org/2701753004/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
(right):

https://codereview.chromium.org/2701753004/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:234: const
AccountId google_account_id_ =
I think gaia_account_id_ is a better name, and more consistent with the rest of
this codebase.

https://codereview.chromium.org/2701753004/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:776: void
MarkOwnership() override {
comment about class whose methods are being overridden.

https://codereview.chromium.org/2701753004/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:802:
IN_PROC_BROWSER_TEST_F(ExistingUserControllerActiveDirectoryTest,
Comment about what's being tested by this.

https://codereview.chromium.org/2701753004/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:821:
IN_PROC_BROWSER_TEST_F(ExistingUserControllerActiveDirectoryTest,
Function comment

https://codereview.chromium.org/2701753004/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:831:
IN_PROC_BROWSER_TEST_F(ExistingUserControllerActiveDirectoryTest,
Function comment

https://codereview.chromium.org/2701753004/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:833:
ExpectLoginFailure();
GAIAAccountLogin_Failure

[commit-bot: I haz the power, 2017-02-17 13:17:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 13:17:16]

Dry run: This issue passed the CQ dry run.

[Roman Sorokin (ftl), 2017-02-17 14:28:43]

https://codereview.chromium.org/2701753004/diff/1/chrome/app/chromeos_strings...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2701753004/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:5493: Sorry, Microsoft® Active Directory®
accounts only are allowed on the device.
On 2017/02/17 13:03:49, achuithb wrote:
> Should probably get a PM to vet this.
> 
> Only Microsoft Active Directory accounts are allowed on this device.

Actually wrote that Google accounts are not allowed

https://codereview.chromium.org/2701753004/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
(right):

https://codereview.chromium.org/2701753004/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:234: const
AccountId google_account_id_ =
On 2017/02/17 13:03:49, achuithb wrote:
> I think gaia_account_id_ is a better name, and more consistent with the rest
of
> this codebase.

Done.

https://codereview.chromium.org/2701753004/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:776: void
MarkOwnership() override {
On 2017/02/17 13:03:49, achuithb wrote:
> comment about class whose methods are being overridden.

Done.

https://codereview.chromium.org/2701753004/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:802:
IN_PROC_BROWSER_TEST_F(ExistingUserControllerActiveDirectoryTest,
On 2017/02/17 13:03:49, achuithb wrote:
> Comment about what's being tested by this.

Done.

https://codereview.chromium.org/2701753004/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:821:
IN_PROC_BROWSER_TEST_F(ExistingUserControllerActiveDirectoryTest,
On 2017/02/17 13:03:49, achuithb wrote:
> Function comment

Done.

https://codereview.chromium.org/2701753004/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:831:
IN_PROC_BROWSER_TEST_F(ExistingUserControllerActiveDirectoryTest,
On 2017/02/17 13:03:49, achuithb wrote:
> Function comment

Done.

https://codereview.chromium.org/2701753004/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:833:
ExpectLoginFailure();
On 2017/02/17 13:03:49, achuithb wrote:
> GAIAAccountLogin_Failure

Done.

[Roman Sorokin (ftl), 2017-02-17 14:29:22]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 14:29:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[achuithb, 2017-02-17 14:59:18]

lgtm

[commit-bot: I haz the power, 2017-02-17 15:26:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 15:26:07]

Dry run: This issue passed the CQ dry run.

[Roman Sorokin (ftl), 2017-02-17 15:26:36]

The CQ bit was checked by rsorokin@chromium.org

[commit-bot: I haz the power, 2017-02-17 15:26:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roman Sorokin (ftl), 2017-02-17 15:27:37]

Description was changed from

==========
Don't let creating Google accounts on the Active Directory devices.

BUG=676297
TEST=ExistingUserControllerActiveDirectoryTest.*
==========

to

==========
Don't let creating Google accounts on the Active Directory devices.

BUG=676297
TEST=ExistingUserControllerActiveDirectoryTest.*
TBR=grt@chromium.org
==========

[commit-bot: I haz the power, 2017-02-17 15:30:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487345196858040,
"parent_rev": "6e5c7766a6d7270a79c6c783ed56d1c234db82f3", "commit_rev":
"44243c3dbc42d90b31f410ba8a778105dc11da6b"}

[commit-bot: I haz the power, 2017-02-17 15:30:49]

Description was changed from

==========
Don't let creating Google accounts on the Active Directory devices.

BUG=676297
TEST=ExistingUserControllerActiveDirectoryTest.*
TBR=grt@chromium.org
==========

to

==========
Don't let creating Google accounts on the Active Directory devices.

BUG=676297
TEST=ExistingUserControllerActiveDirectoryTest.*
TBR=grt@chromium.org

Review-Url: https://codereview.chromium.org/2701753004
Cr-Commit-Position: refs/heads/master@{#451308}
Committed:
https://chromium.googlesource.com/chromium/src/+/44243c3dbc42d90b31f410ba8a77...
==========

[commit-bot: I haz the power, 2017-02-17 15:30:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/44243c3dbc42d90b31f410ba8a77...