Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issue 2701743004: Set "Cancel" button blue in iOS Share extension (Closed)

Created:
3 years, 10 months ago by Olivier
Modified:
3 years, 10 months ago
Reviewers:
gambard
CC:
chromium-reviews, extensions-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, chromium-apps-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set "Cancel" button blue in iOS Share extension At the moment, the button can be tinted by host app. Always set color to blue. BUG=693600 Review-Url: https://codereview.chromium.org/2701743004 Cr-Commit-Position: refs/heads/master@{#451328} Committed: https://chromium.googlesource.com/chromium/src/+/cfa7526644a9bf91d4f119448a216fa690116ec5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ios/chrome/share_extension/share_extension_view.mm View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Olivier
3 years, 10 months ago (2017-02-17 16:55:27 UTC) #2
gambard
lgtm
3 years, 10 months ago (2017-02-17 16:59:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701743004/1
3 years, 10 months ago (2017-02-17 17:03:41 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 17:28:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cfa7526644a9bf91d4f119448a21...

Powered by Google App Engine
This is Rietveld 408576698