Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2701673003: HostCache: always evict stale entries before valid entries (Closed)

Created:
3 years, 10 months ago by mgersh
Modified:
3 years, 10 months ago
Reviewers:
Julia Tuttle
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HostCache: always evict stale entries before valid entries Previously, HostCache would always evict the entry with the earliest expiration time. Because entries can also become stale due to network changes, this could potentially evict a valid entry when stale entries are present in the cache. BUG=692803 Review-Url: https://codereview.chromium.org/2701673003 Cr-Commit-Position: refs/heads/master@{#451395} Committed: https://chromium.googlesource.com/chromium/src/+/9cdf01f7131fa57830221af1156b1a3ca1e11578

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -1 line) Patch
M net/dns/host_cache.cc View 1 chunk +4 lines, -1 line 0 comments Download
M net/dns/host_cache_unittest.cc View 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
mgersh
PTAL
3 years, 10 months ago (2017-02-16 19:21:14 UTC) #2
Julia Tuttle
On 2017/02/16 19:21:14, mgersh wrote: > PTAL lgtm!
3 years, 10 months ago (2017-02-17 18:09:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701673003/1
3 years, 10 months ago (2017-02-17 18:14:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/17412)
3 years, 10 months ago (2017-02-17 19:16:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701673003/1
3 years, 10 months ago (2017-02-17 19:44:28 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 23:25:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9cdf01f7131fa57830221af1156b...

Powered by Google App Engine
This is Rietveld 408576698