CompositorFrameSinkSupportClient::WillDraw needs to take in arguments

CompositorFrameSinkSupportClient::WillDraw needs to take in arguments

SurfaceFactory sends a LocalSurfaceId and a gfx::Rect to its client's WillDraw method, but CompositorFrameSinkSupport doesn't do so. 
This is a problem because we DelegatedFrameHost needs those arguments 
in WillDraw so if we want to switch to CompositorFrameSinkSupport,
CompositorFrameSinkSupport must also forward those arguments.

TBR=cpu@chromium.org

BUG=692880
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2701663003
Cr-Commit-Position: refs/heads/master@{#451206}
Committed: https://chromium.googlesource.com/chromium/src/+/6ede8b88d716c54c8a0d62b9c3907141137b28f8

[Saman Sami, 2017-02-16 19:15:24]

Description was changed from

==========
CompositorFrameSinkSupportClient::WillDraw needs to take in arguments

BUG=692880
==========

to

==========
CompositorFrameSinkSupportClient::WillDraw needs to take in arguments

BUG=692880
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-02-16 19:16:04]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[Saman Sami, 2017-02-16 19:16:51]

Description was changed from

==========
CompositorFrameSinkSupportClient::WillDraw needs to take in arguments

BUG=692880
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
CompositorFrameSinkSupportClient::WillDraw needs to take in arguments

BUG=692880
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-02-16 19:16:51]

samans@chromium.org changed reviewers:
+ fsamuel@chromium.org, jam@chromium.org

[commit-bot: I haz the power, 2017-02-16 19:17:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-02-16 19:18:54]

Description was changed from

==========
CompositorFrameSinkSupportClient::WillDraw needs to take in arguments

BUG=692880
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
CompositorFrameSinkSupportClient::WillDraw needs to take in arguments

So far we did not need the arguments, but DelegatedFrameHost needs them
if we are going to switch to CompositorFrameSinkSupport.

BUG=692880
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-02-16 19:19:07]

Description was changed from

==========
CompositorFrameSinkSupportClient::WillDraw needs to take in arguments

So far we did not need the arguments, but DelegatedFrameHost needs them
if we are going to switch to CompositorFrameSinkSupport.

BUG=692880
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
CompositorFrameSinkSupportClient::WillDraw needs to take in arguments

So far we did not need the arguments, but DelegatedFrameHost needs them
if we are going to switch to CompositorFrameSinkSupport.

TBR=jam@chromium.org

BUG=692880
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-02-16 19:43:12]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[Saman Sami, 2017-02-16 19:43:26]

samans@chromium.org changed reviewers:
+ tsepez@chromium.org

[commit-bot: I haz the power, 2017-02-16 19:44:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-02-16 19:59:17]

Description was changed from

==========
CompositorFrameSinkSupportClient::WillDraw needs to take in arguments

So far we did not need the arguments, but DelegatedFrameHost needs them
if we are going to switch to CompositorFrameSinkSupport.

TBR=jam@chromium.org

BUG=692880
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
CompositorFrameSinkSupportClient::WillDraw needs to take in arguments

So far we did not need the arguments, but DelegatedFrameHost needs them
if we are going to switch to CompositorFrameSinkSupport.

TBR=jam@chromium.org, tsepez@chromium.org

BUG=692880
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[commit-bot: I haz the power, 2017-02-16 20:07:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 20:07:17]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Saman Sami, 2017-02-16 20:17:42]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 20:18:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-02-16 20:23:02]

I think it would be useful to describe how DelegatedFrameHost uses the
parameters. Also, you might want to find other owners given jam@ is OOO.

lgtm

[Tom Sepez, 2017-02-16 20:24:22]

lgtm

[Saman Sami, 2017-02-16 20:40:50]

Description was changed from

==========
CompositorFrameSinkSupportClient::WillDraw needs to take in arguments

So far we did not need the arguments, but DelegatedFrameHost needs them
if we are going to switch to CompositorFrameSinkSupport.

TBR=jam@chromium.org, tsepez@chromium.org

BUG=692880
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
CompositorFrameSinkSupportClient::WillDraw needs to take in arguments

So far we did not need the arguments, but DelegatedFrameHost needs them
if we are going to switch to CompositorFrameSinkSupport.

TBR=tsepez@chromium.org

BUG=692880
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-02-16 20:40:50]

samans@chromium.org changed reviewers:
- jam@chromium.org

[Saman Sami, 2017-02-16 20:43:19]

Description was changed from

==========
CompositorFrameSinkSupportClient::WillDraw needs to take in arguments

So far we did not need the arguments, but DelegatedFrameHost needs them
if we are going to switch to CompositorFrameSinkSupport.

TBR=tsepez@chromium.org

BUG=692880
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
CompositorFrameSinkSupportClient::WillDraw needs to take in arguments

So far we did not need the arguments, but DelegatedFrameHost needs them
if we are going to switch to CompositorFrameSinkSupport.

TBR=cpu@chromium.org

BUG=692880
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-02-16 20:43:19]

samans@chromium.org changed reviewers:
+ cpu@chromium.org

[Saman Sami, 2017-02-16 21:30:09]

Description was changed from

==========
CompositorFrameSinkSupportClient::WillDraw needs to take in arguments

So far we did not need the arguments, but DelegatedFrameHost needs them
if we are going to switch to CompositorFrameSinkSupport.

TBR=cpu@chromium.org

BUG=692880
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
CompositorFrameSinkSupportClient::WillDraw needs to take in arguments

SurfaceFactory sends a LocalSurfaceId and a gfx::Rect to its client's WillDraw
method, but CompositorFrameSinkSupport doesn't do so. 
This is a problem because we DelegatedFrameHost needs those arguments 
in WillDraw so if we want to switch to CompositorFrameSinkSupport,
CompositorFrameSinkSupport must also forward those arguments.

TBR=cpu@chromium.org

BUG=692880
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-02-16 21:31:43]

The CQ bit was unchecked by samans@chromium.org

[Saman Sami, 2017-02-16 21:31:47]

The CQ bit was checked by samans@chromium.org

[commit-bot: I haz the power, 2017-02-16 21:33:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 00:28:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 00:28:03]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Saman Sami, 2017-02-17 01:04:54]

The CQ bit was checked by samans@chromium.org

[commit-bot: I haz the power, 2017-02-17 01:05:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cpu_(ooo_6.6-7.5), 2017-02-17 02:51:44]

cpu@chromium.org changed reviewers:
- cpu@chromium.org

[commit-bot: I haz the power, 2017-02-17 04:22:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487293494066060,
"parent_rev": "6bb957fdd7376485034caeeaad8bc3d3413aa23c", "commit_rev":
"6ede8b88d716c54c8a0d62b9c3907141137b28f8"}

[commit-bot: I haz the power, 2017-02-17 04:24:30]

Description was changed from

==========
CompositorFrameSinkSupportClient::WillDraw needs to take in arguments

SurfaceFactory sends a LocalSurfaceId and a gfx::Rect to its client's WillDraw
method, but CompositorFrameSinkSupport doesn't do so. 
This is a problem because we DelegatedFrameHost needs those arguments 
in WillDraw so if we want to switch to CompositorFrameSinkSupport,
CompositorFrameSinkSupport must also forward those arguments.

TBR=cpu@chromium.org

BUG=692880
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
CompositorFrameSinkSupportClient::WillDraw needs to take in arguments

SurfaceFactory sends a LocalSurfaceId and a gfx::Rect to its client's WillDraw
method, but CompositorFrameSinkSupport doesn't do so. 
This is a problem because we DelegatedFrameHost needs those arguments 
in WillDraw so if we want to switch to CompositorFrameSinkSupport,
CompositorFrameSinkSupport must also forward those arguments.

TBR=cpu@chromium.org

BUG=692880
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2701663003
Cr-Commit-Position: refs/heads/master@{#451206}
Committed:
https://chromium.googlesource.com/chromium/src/+/6ede8b88d716c54c8a0d62b9c390...
==========

[commit-bot: I haz the power, 2017-02-17 04:24:31]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6ede8b88d716c54c8a0d62b9c390...