Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2701643002: [compiler] Remove dead code. (Closed)

Created:
3 years, 10 months ago by neis
Modified:
3 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove dead code. The SpeculativeNumberOp helper lives now in js-type-hint-lowering.cc and is no longer needed in js-typed-lowering.cc. R=mstarzinger@chromium.org BUG= Review-Url: https://codereview.chromium.org/2701643002 Cr-Commit-Position: refs/heads/master@{#43248} Committed: https://chromium.googlesource.com/v8/v8/+/67544daa5d339ba071c4f46c3a1a7358c3a2ad19

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
neis
3 years, 10 months ago (2017-02-16 12:42:07 UTC) #1
Michael Starzinger
LGTM. Thanks!
3 years, 10 months ago (2017-02-16 13:32:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701643002/1
3 years, 10 months ago (2017-02-16 13:34:24 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 13:56:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/67544daa5d339ba071c4f46c3a1a7358c3a...

Powered by Google App Engine
This is Rietveld 408576698