[Media Router] Add DialMediaSinkService and DeviceDescriptionService

chrome/browser/media/router/discovery/media_sink_internal.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/router/discovery/media_sink_internal.h"
 
 #include "base/logging.h"
 #include "base/strings/string_util.h"
 
 namespace media_router {
@@ skipping 46 matching lines @@
       return *dial_data_ == *(other.dial_data_);
     case SinkType::CAST:
       return *cast_data_ == *(other.cast_data_);
     case SinkType::GENERIC:
       return true;
   }
   NOTREACHED();
   return false;
 }
 
+bool MediaSinkInternal::operator!=(const MediaSinkInternal& other) const {
+  return !operator==(other);

[mark a. foltz, 2017/04/12 00:17:18]

Nice :)  I did not know this trick and would have written !(*this == other)

[zhaobin, 2017/04/18 06:58:28]

Acknowledged.

+}
+
 void MediaSinkInternal::set_sink(const MediaSink& sink) {
   sink_ = sink;
 }
 
 void MediaSinkInternal::set_dial_data(const DialSinkExtraData& dial_data) {
   DCHECK(sink_type_ != SinkType::CAST);
   InternalCleanup();
 
   sink_type_ = SinkType::DIAL;
   dial_data_.Init(dial_data);
@@ skipping 70 matching lines @@
     case SinkType::CAST:
       cast_data_.Destroy();
       return;
     case SinkType::GENERIC:
       return;
   }
   NOTREACHED();
 }
 
 DialSinkExtraData::DialSinkExtraData() = default;
+DialSinkExtraData::DialSinkExtraData(const std::string& ip_address,
+                                     const std::string& model_name,
+                                     const std::string& app_url)
+    : model_name(model_name), app_url(app_url) {
+  DCHECK(this->ip_address.AssignFromIPLiteral(ip_address));

[mark a. foltz, 2017/04/12 00:17:18]

This won't be called in release builds, and I feel like we should not check in
unit tests that are guaranteed to fail in release builds.

[zhaobin, 2017/04/18 06:58:27]

Code removed.

+}
 DialSinkExtraData::DialSinkExtraData(const DialSinkExtraData& other) = default;
 DialSinkExtraData::~DialSinkExtraData() = default;
 
 bool DialSinkExtraData::operator==(const DialSinkExtraData& other) const {
   return ip_address == other.ip_address && model_name == other.model_name &&
          app_url == other.app_url;
 }
 
 CastSinkExtraData::CastSinkExtraData() = default;
 CastSinkExtraData::CastSinkExtraData(const CastSinkExtraData& other) = default;
 CastSinkExtraData::~CastSinkExtraData() = default;
 
 bool CastSinkExtraData::operator==(const CastSinkExtraData& other) const {
   return ip_address == other.ip_address && model_name == other.model_name &&
          capabilities == other.capabilities &&
          cast_channel_id == other.cast_channel_id;
 }
 
 }  // namespace media_router