Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2701613008: Fix GN bootstrap (Closed)

Created:
3 years, 10 months ago by Paweł Hajdan Jr.
Modified:
3 years, 10 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, Dirk Pranke, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GN bootstrap BUG=none R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2701613008 . Cr-Commit-Position: refs/heads/master@{#451714} Committed: https://chromium.googlesource.com/chromium/src/+/ddb3cdad576e8414efec789a7b0d31323bf237e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M tools/gn/bootstrap/bootstrap.py View 8 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Paweł Hajdan Jr.
3 years, 10 months ago (2017-02-20 07:52:22 UTC) #2
jochen (gone - plz use gerrit)
why not make an isolated script test that ensures that this doesn't break?
3 years, 10 months ago (2017-02-20 09:24:28 UTC) #3
Paweł Hajdan Jr.
On 2017/02/20 09:24:28, jochen wrote: > why not make an isolated script test that ensures ...
3 years, 10 months ago (2017-02-21 08:05:54 UTC) #4
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-21 08:14:37 UTC) #5
Paweł Hajdan Jr.
3 years, 10 months ago (2017-02-21 08:33:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ddb3cdad576e8414efec789a7b0d31323bf237e9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698