Android: Add VectorDrawable support to TintedImageView

Android: Add VectorDrawable support to TintedImageView

Swapping an ImageView using a VectorDrawable with a TintedImageView
crashes on pre-L Android versions while working without issues on
other. This rebases TintedImageView on the appcompat version of
ImageView to be consistent with the one used in XML

BUG=690332
Review-Url: https://codereview.chromium.org/2701533004
Cr-Commit-Position: refs/heads/master@{#451077}
Committed: https://chromium.googlesource.com/chromium/src/+/1f08de362f51a55b550c025e29c340e773e68ad5

[dgn, 2017-02-16 18:35:00]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[dgn, 2017-02-16 18:36:06]

dgn@chromium.org changed reviewers:
+ bauerb@chromium.org, tedchoc@chromium.org

[dgn, 2017-02-16 18:36:06]

PTAL. https://codereview.chromium.org/2688383005/ made the NTP crash on pre-L.
This fixes it.

[commit-bot: I haz the power, 2017-02-16 18:36:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 19:13:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 19:13:43]

Dry run: This issue passed the CQ dry run.

[Ted C, 2017-02-16 19:14:32]

lgtm, but vector drawables aren't supported to be tinted right?

[dgn, 2017-02-16 19:27:09]

Thanks!

The vector drawable won't be tinted, but in my use case we are clearing the
tint anyway.

On Thu, 16 Feb 2017, 19:14 , <tedchoc@chromium.org> wrote:

lgtm, but vector drawables aren't supported to be tinted right?

https://codereview.chromium.org/2701533004/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dgn, 2017-02-16 19:35:11]

The CQ bit was checked by dgn@chromium.org

[commit-bot: I haz the power, 2017-02-16 19:36:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 20:16:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487273711440470, "parent_rev":
"09994822726a5e65ebc53b048f17a50c50489e60", "commit_rev":
"1f08de362f51a55b550c025e29c340e773e68ad5"}

[commit-bot: I haz the power, 2017-02-16 20:16:58]

Description was changed from

==========
Android: Add VectorDrawable support to TintedImageView

Swapping an ImageView using a VectorDrawable with a TintedImageView
crashes on pre-L Android versions while working without issues on
other. This rebases TintedImageView on the appcompat version of
ImageView to be consistent with the one used in XML

BUG=690332
==========

to

==========
Android: Add VectorDrawable support to TintedImageView

Swapping an ImageView using a VectorDrawable with a TintedImageView
crashes on pre-L Android versions while working without issues on
other. This rebases TintedImageView on the appcompat version of
ImageView to be consistent with the one used in XML

BUG=690332

Review-Url: https://codereview.chromium.org/2701533004
Cr-Commit-Position: refs/heads/master@{#451077}
Committed:
https://chromium.googlesource.com/chromium/src/+/1f08de362f51a55b550c025e29c3...
==========

[commit-bot: I haz the power, 2017-02-16 20:16:59]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1f08de362f51a55b550c025e29c3...