third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp - Issue 2701523003: Don't pixel-snap overflow clips in clip paint property nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Issue 2701523003: Don't pixel-snap overflow clips in clip paint property nodes. (Closed)

Patch Set: Merge branch 'master' into fixclipping Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

index 172d22ae06ce77eada4f4fe52677f2594f78548b..c66dac08edcc4e31027ec51fc7a9f4c7f5150e6b 100644

--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

@@ -615,8 +615,7 @@ void PaintPropertyTreeBuilder::updateOverflowClip(

// like overflow clip.

LayoutRect clipRect;

if (box.shouldClipOverflow()) {

- clipRect = LayoutRect(pixelSnappedIntRect(

- box.overflowClipRect(context.current.paintOffset)));

+ clipRect = LayoutRect(box.overflowClipRect(context.current.paintOffset));

} else {

if (auto* properties = object.getMutableForPainting().paintProperties()) {

context.forceSubtreeUpdate |= properties->clearInnerBorderRadiusClip();