Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2701513005: Mojo EDK: Reduce unused read buffer capacity (Closed)

Created:
3 years, 10 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 10 months ago
Reviewers:
yzshen1
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo EDK: Reduce unused read buffer capacity Reduces the unused read buffer capacity from 64k to 4k. A simple empirical measurement shows that ~90% of all messages received by the browser in a "typical" browsing session are no larger than 4k, so the extra allocations here should not have a significant performance impact. BUG=692369 Review-Url: https://codereview.chromium.org/2701513005 Cr-Commit-Position: refs/heads/master@{#451209} Committed: https://chromium.googlesource.com/chromium/src/+/adb217e7938f1f84c3f528bec160f9cfa35fb74d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/edk/system/channel.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Ken Rockot(use gerrit already)
PTAL
3 years, 10 months ago (2017-02-16 23:27:25 UTC) #3
yzshen1
lgtm
3 years, 10 months ago (2017-02-16 23:28:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701513005/1
3 years, 10 months ago (2017-02-17 02:42:49 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 04:31:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/adb217e7938f1f84c3f528bec160...

Powered by Google App Engine
This is Rietveld 408576698