Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2701503004: ChromeOS OOBE: fix focus indicator on Accessibility page. (Closed)

Created:
3 years, 10 months ago by Alexander Alekseev
Modified:
3 years, 10 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS OOBE: fix focus indicator on Accessibility page. This CL fixes "not completely round" focus indicator of the paper-toggle buttons on ChromeOS OOBE Accessibility dialog. BUG=691987 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2701503004 Cr-Commit-Position: refs/heads/master@{#451245} Committed: https://chromium.googlesource.com/chromium/src/+/0797f19935f16c4e0a57f74fcd82e978ec660e42

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update after review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_a11y_option.css View 1 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_a11y_option.html View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Alexander Alekseev
This is mostly a copy of styles in settings. (Size, color and minor details are ...
3 years, 10 months ago (2017-02-16 11:04:59 UTC) #3
achuithb
lgtm https://codereview.chromium.org/2701503004/diff/1/chrome/browser/resources/chromeos/login/oobe_a11y_option.css File chrome/browser/resources/chromeos/login/oobe_a11y_option.css (right): https://codereview.chromium.org/2701503004/diff/1/chrome/browser/resources/chromeos/login/oobe_a11y_option.css#newcode17 chrome/browser/resources/chromeos/login/oobe_a11y_option.css:17: /* paper-toggle-button has fixed width of 36px. Make ...
3 years, 10 months ago (2017-02-16 11:10:59 UTC) #6
Alexander Alekseev
https://codereview.chromium.org/2701503004/diff/1/chrome/browser/resources/chromeos/login/oobe_a11y_option.css File chrome/browser/resources/chromeos/login/oobe_a11y_option.css (right): https://codereview.chromium.org/2701503004/diff/1/chrome/browser/resources/chromeos/login/oobe_a11y_option.css#newcode17 chrome/browser/resources/chromeos/login/oobe_a11y_option.css:17: /* paper-toggle-button has fixed width of 36px. Make it ...
3 years, 10 months ago (2017-02-16 11:35:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701503004/20001
3 years, 10 months ago (2017-02-17 02:28:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on ...
3 years, 10 months ago (2017-02-17 04:31:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701503004/20001
3 years, 10 months ago (2017-02-17 05:23:56 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 06:24:03 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0797f19935f16c4e0a57f74fcd82...

Powered by Google App Engine
This is Rietveld 408576698