Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: extensions/test/extension_test_notification_observer.cc

Issue 2701473007: Switch WindowedNotificationObserver to use base::RunLoop. (Closed)
Patch Set: Fix tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/test/extension_test_notification_observer.cc
diff --git a/extensions/test/extension_test_notification_observer.cc b/extensions/test/extension_test_notification_observer.cc
index 0e4d75d0ccdcbfa8cfe6e07dfb27c4b3ab52ef06..a18e75fc4914fef6ae2838f5de18fed360b3aa9e 100644
--- a/extensions/test/extension_test_notification_observer.cc
+++ b/extensions/test/extension_test_notification_observer.cc
@@ -140,6 +140,8 @@ void ExtensionTestNotificationObserver::Watch(
void ExtensionTestNotificationObserver::Wait() {
observer_->Wait();
+ // TODO(...): Find out why tests fail without it.
Alexander Semashko 2017/02/21 21:33:47 Please advise what to do here, e.g. assign this TO
Devlin 2017/02/22 00:26:48 Filing a bug would probably be best here, ideally
Alexander Semashko 2017/02/22 17:10:08 Done, https://bugs.chromium.org/p/chromium/issues/
+ content::RunAllPendingInMessageLoop();
registrar_.RemoveAll();
observer_.reset();

Powered by Google App Engine
This is Rietveld 408576698