Switch WindowedNotificationObserver to use base::RunLoop.

extensions/test/extension_test_notification_observer.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/test/extension_test_notification_observer.h"
 
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/notification_service.h"
@@ skipping 122 matching lines @@
 void ExtensionTestNotificationObserver::Watch(
     int type,
     const content::NotificationSource& source) {
   CHECK(!observer_);
   observer_.reset(new content::WindowedNotificationObserver(type, source));
   registrar_.Add(this, type, source);
 }
 
 void ExtensionTestNotificationObserver::Wait() {
   observer_->Wait();
+  // TODO(...): Find out why tests fail without it.

[Alexander Semashko, 2017/02/21 21:33:47]

Please advise what to do here, e.g. assign this TODO to somebody or create a
bug.
As to what is going on here: some tests started failing after the removal of
implicit deferred quit in the WindowedNotificationObserver. This means that
waiting for the notification itself is not sufficient. What is needed here is to
find out what is missing, and (probably) add code to wait for that event(s). Or
just leave RunAllPending if it turns out that these events do not involve other
threads/processes and happen without any delay.

[Devlin, 2017/02/22 00:26:48]

Filing a bug would probably be best here, ideally with a list of the tests that
are affected.

[Alexander Semashko, 2017/02/22 17:10:08]

Done, https://bugs.chromium.org/p/chromium/issues/detail?id=695073

+  content::RunAllPendingInMessageLoop();
 
   registrar_.RemoveAll();
   observer_.reset();
 }
 
 void ExtensionTestNotificationObserver::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
   switch (type) {
@@ skipping 48 matching lines @@
   condition_.Reset();
   quit_closure_.Reset();
 }
 
 void ExtensionTestNotificationObserver::MaybeQuit() {
   if (condition_.Run())
     quit_closure_.Run();
 }
 
 }  // namespace extensions