Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 2701473005: Make purge+throttled feature work with memory coordinator (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by bashi
Modified:
3 months ago
Reviewers:
haraken, kinuko, tasak
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make purge+throttled feature work with memory coordinator Purge+throttled (previously called purge+suspend) used to depend on MemoryCoordinatorClient::OnStateChange() and that's why we couldn't enable purge+throttled and memory coordinator at the same time. As of crrev.com/2695923003 all purging logic has moved to MemoryCoordinatorClient::OnPurgeMemory(), which can be used by both memory coordinator and purge+throttled feature. Both features don't have to be mutually exclusive anymore. BUG=635419 Review-Url: https://codereview.chromium.org/2701473005 Cr-Commit-Position: refs/heads/master@{#451207} Committed: https://chromium.googlesource.com/chromium/src/+/9c3ce4099b593b5172fe94028c949730f72716ef

Patch Set 1 #

Messages

Total messages: 20 (11 generated)
bashi
tasak@: does this look correct to you? Please let me know if I missed something.
3 months ago (2017-02-16 07:42:53 UTC) #4
tasak
lgtm
3 months ago (2017-02-16 12:00:26 UTC) #7
haraken
LGTM
3 months ago (2017-02-16 12:00:54 UTC) #8
bashi
kinuko@: PTAL?
3 months ago (2017-02-16 23:00:23 UTC) #10
kinuko
lgtm
3 months ago (2017-02-17 01:55:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701473005/1
3 months ago (2017-02-17 01:57:44 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 months ago (2017-02-17 04:01:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701473005/1
3 months ago (2017-02-17 04:13:20 UTC) #17
commit-bot: I haz the power
3 months ago (2017-02-17 04:28:01 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9c3ce4099b593b5172fe94028c94...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06