Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2701463002: Fixed title updating for back forward navigation. (Closed)

Created:
3 years, 10 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Fixed title updating for back forward navigation. Chrome relies on KVO compliant "title" property to subscribe for title updates. If this KVO change happens during then navigation it is unclear if title was changes for the previous page, or the navigation was committed and title was changed for the new page. So if there is a navigation in progress WebController should ignore KVO change, but it should always attempt to update title when navigation is committed. BUG=688047, 677356 Review-Url: https://codereview.chromium.org/2685803002 Cr-Commit-Position: refs/heads/master@{#449527} (cherry picked from commit 487e4cfd53bac5944dad49cbce3b939a0c7bf035) Review-Url: https://codereview.chromium.org/2701463002 . Cr-Commit-Position: refs/branch-heads/2987@{#521} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/55217cf9efff8866160932c1614077d4ed43a2d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -31 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 3 chunks +2 lines, -25 lines 0 comments Download
M ios/chrome/browser/tabs/tab_unittest.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 4 chunks +34 lines, -6 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_navigation_states.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_navigation_states.mm View 1 chunk +9 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Eugene But (OOO till 7-30)
3 years, 10 months ago (2017-02-15 16:31:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
55217cf9efff8866160932c1614077d4ed43a2d3.

Powered by Google App Engine
This is Rietveld 408576698