Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 2701453002: android: Tell GSA whether Chrome can listen to account change broadcasts. (Closed)

Created:
3 years, 10 months ago by Benoit L
Modified:
3 years, 10 months ago
Reviewers:
pasko, Yusuf
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Tell GSA whether Chrome can listen to account change broadcasts. For GSA to know that Chrome will receive the broadcasts, we need to tell it that the matching permission is granted by the system. BUG=614388 Review-Url: https://codereview.chromium.org/2701453002 Cr-Commit-Position: refs/heads/master@{#451740} Committed: https://chromium.googlesource.com/chromium/src/+/621821c9c2eeb41418191826528871b109ec5908

Patch Set 1 #

Patch Set 2 : Update key name. #

Patch Set 3 : Add comments. #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAAccountChangeListener.java View 1 2 2 chunks +17 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (18 generated)
Benoit L
3 years, 10 months ago (2017-02-16 16:23:21 UTC) #2
Benoit L
On 2017/02/16 16:23:21, Benoit L wrote: ping :-)
3 years, 10 months ago (2017-02-20 09:45:29 UTC) #7
Benoit L
3 years, 10 months ago (2017-02-20 16:27:37 UTC) #11
pasko
lgtm. Is there a way to unittest this?
3 years, 10 months ago (2017-02-20 17:30:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701453002/60001
3 years, 10 months ago (2017-02-21 12:32:49 UTC) #21
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 12:37:46 UTC) #24
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/621821c9c2eeb414181918265288...

Powered by Google App Engine
This is Rietveld 408576698