third_party/WebKit/LayoutTests/media/controls/download-button-displays-with-preload-none.html - Issue 2701433003: Hide overlay play button if it can't be shown without clipping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/controls/download-button-displays-with-preload-none.html

Issue 2701433003: Hide overlay play button if it can't be shown without clipping (Closed)

Patch Set: Rebase and fix Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/controls-cast-button-narrow.html ('k') | third_party/WebKit/LayoutTests/media/controls/overlay-play-button.js » ('j') | third_party/WebKit/Source/core/html/shadow/MediaControls.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/controls/download-button-displays-with-preload-none.html

diff --git a/third_party/WebKit/LayoutTests/media/controls/download-button-displays-with-preload-none.html b/third_party/WebKit/LayoutTests/media/controls/download-button-displays-with-preload-none.html

index 910af211b238483f9d4af7feeeb5f3ecac1e7975..89aaad2a8e5b02f06040e9555f464961c2457077 100644

--- a/third_party/WebKit/LayoutTests/media/controls/download-button-displays-with-preload-none.html

+++ b/third_party/WebKit/LayoutTests/media/controls/download-button-displays-with-preload-none.html

@@ -21,11 +21,5 @@ async_test(function(t) {

throw 'Failed to find download button';

return button;

}

- function isVisible(button) {

- var computedStyle = getComputedStyle(button);

- return computedStyle.display !== "none" &&

- computedStyle.visibility === "visible";

- }

});

</script>