third_party/WebKit/LayoutTests/media/controls/download-button-displays-with-preload-none.html - Issue 2701433003: Hide overlay play button if it can't be shown without clipping

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/controls/download-button-displays-with-preload-none.html

Issue 2701433003: Hide overlay play button if it can't be shown without clipping (Closed)

Patch Set: Rebase and fix Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/controls-cast-button-narrow.html ('k') | third_party/WebKit/LayoutTests/media/controls/overlay-play-button.js » ('j') | third_party/WebKit/Source/core/html/shadow/MediaControls.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>media controls download button preload none</title>	2 <title>media controls download button preload none</title>

3 <script src="../../resources/testharness.js"></script>	3 <script src="../../resources/testharness.js"></script>

4 <script src="../../resources/testharnessreport.js"></script>	4 <script src="../../resources/testharnessreport.js"></script>

5 <script src="../media-file.js"></script>	5 <script src="../media-file.js"></script>

6 <script src="../media-controls.js"></script>	6 <script src="../media-controls.js"></script>

7 <video controls preload="none" src="https://someexample.example/example.mp4"></v ideo>	7 <video controls preload="none" src="https://someexample.example/example.mp4"></v ideo>

8 <script>	8 <script>

9 async_test(function(t) {	9 async_test(function(t) {

10 var video = document.querySelector("video");	10 var video = document.querySelector("video");

11	11

12 testRunner.layoutAndPaintAsyncThen(t.step_func_done(function() {	12 testRunner.layoutAndPaintAsyncThen(t.step_func_done(function() {

13 assert_true(isVisible(downloadButton(video)));	13 assert_true(isVisible(downloadButton(video)));

14 }));	14 }));

15	15

16 function downloadButton(videoElement) {	16 function downloadButton(videoElement) {

17 var controlID = '-internal-media-controls-download-button';	17 var controlID = '-internal-media-controls-download-button';

18 var button = mediaControlsElement(	18 var button = mediaControlsElement(

19 window.internals.shadowRoot(videoElement).firstChild, controlID);	19 window.internals.shadowRoot(videoElement).firstChild, controlID);

20 if (!button)	20 if (!button)

21 throw 'Failed to find download button';	21 throw 'Failed to find download button';

22 return button;	22 return button;

23 }	23 }

24

25 function isVisible(button) {

26 var computedStyle = getComputedStyle(button);

27 return computedStyle.display !== "none" &&

28 computedStyle.visibility === "visible";

29 }

30 });	24 });

31 </script>	25 </script>

OLD	NEW